Re: [Libvirt-cim] [PATCH 2 of 2] Add input device support to device_parsing and Virt_Device

Dan Smith wrote:

KR> @@ -115,6 +121,7 @@

KR> struct virt_device *dev_graphics; KR> struct virt_device *dev_emu; KR> + struct virt_device *dev_input;

Are you going to add a count as well? I think that by default virt-manager configures guests with a PS2 mouse and a USB tablet. Not sure if that's worth keeping track of, but we definitely want to decide and make sure we don't ever create a list of the above that won't get fully free()'d if we just expect it to be a single device.

Yep, this makes sense. I'll follow up with this change. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com