Re: [Libvirt-cim] [PATCH 0/3] cimtest follow patch

On 04/08/2013 06:16 AM, Wenchao Xia wrote: > This is a patch follows John's 9 patches for cimtest, after it > cimtest should only fail 3 case on RH6.4: > HostSystem - 01_enum.py: FAIL > HostSystem - 03_hs_to_settdefcap.py: FAIL > VirtualSystemManagementService - 19_definenetwork_ers.py: FAIL > > This patch is only for review and test, it may need adjust and merge > with John's patch, and change to author name(not root :|), please > do not push directly. > > root (3): > test: common_util, use number to check version > test: rasd use int as comparation condtion for libvirt version > test: RPCS fix nfs issue > > .../12_create_netfs_storagevolume_errs.py | 2 +- > suites/libvirt-cim/lib/XenKvmLib/common_util.py | 32 ++++++++++++++++--- > suites/libvirt-cim/lib/XenKvmLib/pool.py | 8 ++-- > suites/libvirt-cim/lib/XenKvmLib/rasd.py | 7 ++-- > 4 files changed, 36 insertions(+), 13 deletions(-) > > While it seems the change resolves some issues I saw in my initial run, I think the official patch needs to describe the problem/symptom and resolution more clearly. In particular, is the change because cimtest was improperly handling the result of the "virsh -v"? Was this only a rhel64 issue?