Dan Smith wrote:
JG> I realize it's a more logical abbreviation than
"ref", but we use
JG> "ref" in so many places that I think it's pretty firmly
JG> established
For the parameter, I think source_ref would be fine. I don't think
changing it to not include "ref" makes it more clear, since the
convention (as it seems to me) is that the object path you pass in as
the "subject" of an operation is called the "reference".
For the "refinst" local variable, I think leaving "ref" in the name
also makes sense. The goal of the function is to "make a reference",
so "refinst" seems to be a reasonable name :)
JG> I personally always see "op" and think "operand" or
"operation." I
JG> would recommend a compromise of "source_ref" for that one.
Me too! I'd be okay with "source_ref", but I question how much more
clarity it will bring given how much patch churn it will produce.
However, if others want this change, I'm okay with it.
Thanks for the comments.
I was resending the patch as "variable renaming
in make_ref() of associations".
Yes, its very good to question this patch. And the more I think about,
the more I find, that there is the possibility to generalize the content
of make_ref() - because at the end most of the association's make_ref()
will look the same, besides the different association class names. I
will send out the patch for this idea.
--
Regards
Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor
heidieck(a)linux.vnet.ibm.com
**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294