Yogananth Subramanian wrote:
# HG changeset patch # User anantyog@linux.vnet.ibm.com # Date 1249473859 25200 # Node ID 9b1015d9ecc67d973be7a95df2bbabf6ba6632bd # Parent 0fe8417e16fce456f1a7049f196340bcb58a14d1 [Test] Test case to test setting UUID by user
This test defines a domain with user specified UUID
Signed-off-by: Yogananth Subramanian <anantyog@linux.vnet.ibm.com>
diff -r 0fe8417e16fc -r 9b1015d9ecc6 suites/libvirt-cim/cimtest/VSSD/05_set_uuid.py --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/suites/libvirt-cim/cimtest/VSSD/05_set_uuid.py Wed Aug 05 05:04:19 2009 -0700 @@ -0,0 +1,86 @@ +#!/usr/bin/python +# +# Copyright 2009 IBM Corp. +# +# Authors: +# Yogananth Subramanian <anantyog@linux.vnet.ibm.com> +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +#
A small description will be good.
+ +import sys +from XenKvmLib import vsms +from XenKvmLib import vxml +from CimTest.Globals import logger +from CimTest.ReturnCodes import PASS, FAIL +from XenKvmLib.const import do_main +from XenKvmLib.classes import get_typed_class +from XenKvmLib.enumclass import GetInstance + +sup_types = ['Xen', 'KVM', 'XenFV', 'LXC'] +default_dom = 'uuid_domain' +uuid = "05ea345a-4539-57d8-abb4-d4fc858641f3"
Instead of hardcoding the uuid can you use randint() and generate some random values in the uuid may be something like "05ea345a-%s-57d8-abb4-d4fc858641f3" % randint(1000, 9999) or something similar.. Like that we hope that we are having a UUID which could be unique otherwise the test might just error out.
+ +def get_vssd(ip, virt, get_cim_inst): + cn = get_typed_class(virt, "VirtualSystemSettingData") + inst = None + + try: + if virt == "XenFV": + virt = "Xen" + + key_list = {"InstanceID" : "%s:%s" % (virt, default_dom) } + inst = GetInstance(ip, cn, key_list, get_cim_inst) + + except Exception, details: + logger.error(details) + return FAIL, inst + + if inst is None:
Error message will be good.
+ return FAIL, inst + + return PASS, inst + +@do_main(sup_types) +def main(): + options = main.options + + service = vsms.get_vsms_class(options.virt)(options.ip) + + cxml = vxml.get_class(options.virt)(default_dom, uuid=uuid) + ret = cxml.cim_define(options.ip) + if not ret: + logger.error("Failed to define the dom: %s", default_dom) + return FAIL
Better if we include the cim_define as well in the try..except block...
+ + try: + status, inst = get_vssd(options.ip, options.virt, True) + if status != PASS: + raise Exception("Failed to get the VSSD instance for %s"% + default_dom) + + if inst['UUID'] != uuid: + raise Exception(" UUID is differnet from the one set by the user")
would be good that we confirm the VVSD.ElementName has the expected domain name.
+ + except Exception, details: + logger.error(details) + status = FAIL + + cxml.undefine(options.ip) + return status + +if __name__ == "__main__": + sys.exit(main()) +
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com