Deepti B. Kalakeri wrote:
# HG changeset patch # User Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com> # Date 1213102213 25200 # Node ID 342e77cf74f7685878555d30678b5ad07a3893f5 # Parent ca8841f47805d5d2a23069220563713412d6a7bd [TEST] Fixing the tc 40_RSC_start.py of ComputerSystem.
The tc was passing with false positive. The parameters passed to check_attributes() were incorrect and fixed it.
Signed-off-by: Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com>
diff -r ca8841f47805 -r 342e77cf74f7 suites/libvirt-cim/cimtest/ComputerSystem/40_RSC_start.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/40_RSC_start.py Fri Jun 06 02:05:34 2008 -0700 +++ b/suites/libvirt-cim/cimtest/ComputerSystem/40_RSC_start.py Tue Jun 10 05:50:13 2008 -0700 @@ -85,7 +85,7 @@ def main(): raise Exception("Unable start dom %s using RequestedStateChange()", default_dom)
- rc = check_attributes(domain_name, ip, options.virt) + rc = check_attributes(default_dom, options.ip, options.virt) if rc != 0: raise Exception("Attributes for %s not set as expected.", default_dom)
Good catch! Since this was a false positive, can you also include a fix that would cause the test to return a failure without this patch applied? It looks like there is an issue with the way the test is reporting status. Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com