Re: [Libvirt-cim] [PATCH] Make NetworkPool use libvirt's virtual network API
Dan Smith wrote:
# HG changeset patch
# User Dan Smith <danms(a)us.ibm.com>
# Date 1199297921 28800
# Node ID 7d60f44ffb2d1e4efccd1b46bd184d2ca57063c0
# Parent 84b72fff34f65ad578d70fcc67b141510e34e24e
Make NetworkPool use libvirt's virtual network API
This means that you no longer see a NetworkPool for each bridge on the
system, but rather one per configured virtual network in libvirt. The
id is NetworkPool/NetName, and the Caption property of the instance
includes the bridge name for reference.
This change removes the need for the contents of hostres.{c,h}, so it is
removed here. That makes the net change -85 lines of pure goodness.
This patch tested out fine and looks good. One thing though, it causes
EAFP and RAFP queries with a NetworkPort ref to fail. This is because
netpool_member_of(), which eventually gets called by pool_member_of(),
uses the bridge name to construct the InstanceID.
Since the net_device struct doesn't have a virtual network element, I'm
guessing this needs to be a separate patch.
Failing query:
wbemcli ain -ac Xen_ElementAllocatedFromPool
'http://localhost:5988/root/virt:Xen_NetworkPool.InstanceID="NetworkPool/default"'
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com