Re: [Libvirt-cim] [PATCH 4 of 6] Add NetworkPort functionality to SettingsDefineCapabilities. All static, max may become dynamic
On Thu, Nov 08, 2007 at 03:58:26PM -0800, Dan Smith wrote:
JG> + uint16_t num_nics = 6;
JG> + struct sdc_rasd_prop *rasd = NULL;
JG> +
JG> + struct sdc_rasd_prop tmp[] = {
JG> + {"InstanceID", (CMPIValue *)"Maximum",
CMPI_chars},
JG> + {"VirtualQuantity", (CMPIValue *)&num_nics,
CMPI_uint16},
JG> + PROP_END
JG> + };
The maximum NIC count is probably different for KVM and Xen, and I
imagine this function should be intelligent in the future. Could we
at least pull the '6' out to a constant like XEN_MAX_VIF or something?
As that bug points out, 6 sounds dangerously low for a virtual interface:
https://bugzilla.redhat.com/show_bug.cgi?id=273421
Any chance to also increase this at least up to 32 ?
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/