Re: [Libvirt-cim] [PATCH] [TEST] #2 Modifying devices.py to fix tc 01_netport.py which was failing on F9 libvirt-cim rpm

22 Jun 2008


      Deepti B Kalakeri wrote:
...
Kaitlin Rupert wrote:
...
...
+# The branch has to be removed once the new rpm
+# including the changes in revision 599 is available.
+# The value of LinkTechnology should be set to 2 for
+# network, bridge and ethernet type interfaces.
+if net_rev > CIM_REV:
You'll want this to be net_rev >= CIM_REV because the change went in 
with changeset 599.
If we make this condition as net_rev >= CIM_REV, then for the case where 
net_rev == CIM_REV = 599 , the LinkTechnology_Ethernet = 0 instead of 
LinkTechnology_Ethernet = 2 which is not what is expected , correct ?
Oops, sorry Deepti.  You're right.  I misread the patch when I looked at 
it on Friday.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin@linux.vnet.ibm.com