Re: [Libvirt-cim] [PATCH 3 of 4] [TEST] Adding new tc to verify DiskPool Deletion using DeleteResourcePool
Kaitlin Rupert wrote:
Deepti B. Kalakeri wrote:
> # HG changeset patch
> # User Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com>
> # Date 1243503501 25200
> # Node ID ff0fb8fca1512987cb6a8210e7a3e95396dfa0a9
> # Parent 13e68baa2f6de1737a7ad17e9d4909782d3fe192
> [TEST] Adding new tc to verify DiskPool Deletion using
> DeleteResourcePool.
>
> Tested with KVM on F10 with current sources.
> Signed-off-by: Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com>
>
> diff -r 13e68baa2f6d -r ff0fb8fca151
> suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/09_DeleteDiskPool.py
>
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++
> b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/09_DeleteDiskPool.py
> Thu May 28 02:38:21 2009 -0700
No complaints on this patch.. just a question. =) Do you plan on
updating this test case to support deletion of other disk pool types?
All the pool types should be identical. So if you plan on using
different test cases, it would be a good idea to put parts of this
test case into a function (or functions) at some point later on.
Yes we should be supporting the deletion of the other disk / net types.
When that happens we can see if we need to write different functions.
For now the DeleteResourcePool() has atleast one test for verification.
Do you think we should immediately implement the deletion of the other
types as well ?
--
Thanks and Regards,
Deepti B. Kalakeri
IBM Linux Technology Center
deeptik(a)linux.vnet.ibm.com