Re: [Libvirt-cim] [PATCH 1 of 2] Add preliminary XML-parsing support for Xen FV domains
KR> This should probably be a CU_DEBUG() statement.
Actually, it should be removed. That was left over from some debug.
Thanks :)
> +
> + free(dom->os_info.pv.type);
> + if (dom->type == DOMAIN_XENPV) {
> + free(dom->os_info.pv.kernel);
> + free(dom->os_info.pv.initrd);
> + free(dom->os_info.pv.cmdline);
> + } else if (dom->type == DOMAIN_XENFV) {
> + free(dom->os_info.fv.loader);
> + free(dom->os_info.fv.boot);
> + } else {
> + CU_DEBUG("Unknown domain type %i", dom->type);
> + }
KR> Does os_info.fv.type need to be freed as well?
No, because os_info.pv.type and os_info.fv_type are the same value.
However, this is ugly and left over from earlier bits in the
implementation. I'll change it up to use the type switch to free the
correct field in the body of the if.
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms(a)us.ibm.com
Attachments:
- attachment.sig (application/pgp-signature — 188 bytes)