On 08/23/2013 11:48 PM, John Ferlan wrote:
On 08/15/2013 10:48 AM, Viktor Mihajlovski wrote:
From: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
In the DefineSystem call the architecture, machine and emulator for KVM are set to the hypervisor-specific default values if they did not get provided. This now allows architecture based decision making in the CIM providers to work for all platforms.
Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com> Reviewed-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> --- src/Virt_VirtualSystemManagementService.c | 130 ++++++++++++----------------- 1 file changed, 55 insertions(+), 75 deletions(-)
This patch had some coverity - resource_leak issues... See below
And fails cimtest miserably... I'll dig some more later to see if I find something, but I have to leave for the day now...
Thanks for the review and testing. Indeed, the memory leak was a review escape from my side. We'll send out a revised version of patches 3 and 4 soon. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294