Re: [Libvirt-cim] [PATCH 4/4] VSSM: Set default values based on libvirt capabilities on DefineSystem calls

On 08/15/2013 10:48 AM, Viktor Mihajlovski wrote: > From: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > > In the DefineSystem call the architecture, machine and emulator for KVM are set > to the hypervisor-specific default values if they did not get provided. > This now allows architecture based decision making in the CIM providers to > work for all platforms. > > Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com&gt; > --- > src/Virt_VirtualSystemManagementService.c | 130 ++++++++++++----------------- > 1 file changed, 55 insertions(+), 75 deletions(-) > This patch had some coverity - resource_leak issues... See below And fails cimtest miserably... I'll dig some more later to see if I find something, but I have to leave for the day now...