Re: [Libvirt-cim] [PATCH] [TEST] Update VSMigrationS.02 for XenFV support, also convert test_xml call to vxml
-from XenKvmLib.test_doms import define_test_domain,
start_test_domain, destroy_and_undefine_domain
-from XenKvmLib.test_xml import *
+from XenKvmLib.test_doms import destroy_and_undefine_domain
Can you replace the destroy_and_undefine_domain() calls with .destroy()
and .undefine() calls?
-def setup_env(ip, migration_list, local_migrate):
+def setup_env(ip, migration_list, local_migrate, virt='Xen'):
Since this is an internal function, it should be:
def setup_env(ip, migration_list, local_migrate, virt)
The caller should supply a value for virt whenever it calls this function.
+def start_guest(ip, guest_name, type, virt='Xen'):
Same here.
+
time.sleep(10)
Can this be replaced by poll_for_state_change()?
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com