Re: [Libvirt-cim] [PATCH] Make net_max callback smarter

JG> # HG changeset patch JG> # User Jay Gagnon <grendel(a)linux.vnet.ibm.com&gt; JG> # Date 1195070622 18000 JG> # Node ID cf3c1b32e71d9a95b3c95ebf3f3622bd39a4a4e3 JG> # Parent 1828b3b30fe476fbae1bf31d99c999ba548911f5 JG> Make net_max callback smarter. JG> Xen 3.0.x supports up to 4 JG> Xen 3.1.x supports up to 8 JG> KVM supports up to 32 If there is no way to determine what the current implementation supports via libvirt, I'm inclined to say that we should advertise the maximum as something that is likely to be sane for most installations, since it isn't an enforced limit. Right now, 8 is hardcoded in vl.c. What about putting the Xen (>3.1.0) and QEMU limits in configure and #include<config.h> here to get the values? That way, we can set them there but make them easily overridable in the case that someone is building the package to run against a modified Xen or QEMU. I'll commit this and cook up a patch for discussion. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com