JG> I realize it's a more logical abbreviation than "ref", but we use JG> "ref" in so many places that I think it's pretty firmly JG> established For the parameter, I think source_ref would be fine. I don't think changing it to not include "ref" makes it more clear, since the convention (as it seems to me) is that the object path you pass in as the "subject" of an operation is called the "reference". For the "refinst" local variable, I think leaving "ref" in the name also makes sense. The goal of the function is to "make a reference", so "refinst" seems to be a reasonable name :) JG> I personally always see "op" and think "operand" or "operation." I JG> would recommend a compromise of "source_ref" for that one. Me too! I'd be okay with "source_ref", but I question how much more clarity it will bring given how much patch churn it will produce. However, if others want this change, I'm okay with it. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com