Hi, John All patches looks fine. There is s small code style issue: change from: if (a==b) xxxxx; to: if (a==b){ xxxx; } Since libvirt-cim lacks a script to check the code style I used qemu's script to do it, which reported this. I directly changed them in your patch, hope you are OK with it. Another change is made: For those patches using new interface, I added macro to enable them, and by default they are not used, to avoid inconsistent of build env and runtime env, and silent routine change when build env changes, since we have not set the requirement in spec file. Actually I think we should change it in configure in the future.
This series replaces my last set. It is a followup after rebase and rework to:
https://www.redhat.com/archives/libvirt-cim/2013-March/msg00029.html
Changes in v2: * Rework libxkutil/cs_util_instance.c to mirror functions as requested * Rework src/Virt_DevicePool.c to mirror functions as requested * Just merged the Makefile.am changes into one * Previous patch 4/10 to CSI is removed due to code change already posted
Still to be reviewed is Makefile.am.
John Ferlan (8): Makefile.am: Remove the $(top_srcdir) from subst command libvirt-cim.spec: Use systemctl for tog-pegasus restart Remove empty newline at bottom xmlgen: Only support script on bridge for xen domains libxkutil: Use virConnectListAllDomains() to fetch domains libxkutil: Adjust get_dominfo() logic DevicePool: Use the virConnectListAll interfaces register: Adjust the chatter output
Makefile.am | 18 +-- libvirt-cim.spec.in | 12 +- libxkutil/cs_util_instance.c | 24 ++++ libxkutil/device_parsing.c | 7 +- libxkutil/xmlgen.c | 25 +++-- provider-register.sh | 9 +- schema/SwitchService.registration | 1 - src/Virt_DevicePool.c | 230 ++++++++++++++++++++++++++++++++++++++ 8 files changed, 296 insertions(+), 30 deletions(-)
-- Best Regards Wenchao Xia