Re: [Libvirt-cim] [PATCH 0/2] cimtest support for consoles

On 10/11/2013 07:09 AM, Viktor Mihajlovski wrote: > This series extends the KVM cimtests with the verification of > the console instrumentation. > If the tested libvirt-cim provider has the necessary release > level, the test domains are instantiated with a console. > The other patch deals with the fact that certain device types > (like graphics) are supported on s390. > > I ran the tests on an x86 system as well seeing no regressions, > but an independent test run would be welcome... > > Viktor Mihajlovski (2): > cimtest: Adding support for ConsoleRASD > cimtest: Fix s390 failures > Not sure how to approach this series. On the one hand things look good; however, when run with Xu Wang's 48 patch series it seems there's assumptions in one set of patches or the other. In particular, there's numerous failures with the libvirt message "Only the first console can be a serial port", which means for some reason there's more than one console in the guest configured to use the serial line. Since patch 1/2 deals with console's I have to assume that it's the reason/cause for what I've seen. I haven't had the time to dig deep on it though, but I guess I'd ask - is the code that seems to add a console to a guest ever (or need to check) whether the guest already has one? Would the 48 patch series somehow "assume" a need to put a console in an others list. Just throwing random ideas out there. It's been a long day.