Re: [Libvirt-cim] [PATCH 00/20] REWORK/PARIAL: Changes to solve unsupported tag issue
On 11/15/2013 11:04 AM, Viktor Mihajlovski wrote:
On 11/15/2013 01:23 AM, John Ferlan wrote:
> This is a *partial rework* of Xu Wang's patches sent last month:
>
> https://www.redhat.com/archives/libvirt-cim/2013-October/msg00081.html
>
> Although not the complete set of changes - it's a good stopping point
> insomuch as it handles the "others" parsing. If this looks good, I can
> push it, then work through the changes to write the xml.
>
> I have run all the changes through cimtest - even with the patches on the
> list from Viktor. No new issues are found.
>
>
wow, hats off to that :-)
thanks - it was a way to review too as the series was just so large...
However I need to report an issue running on s390, cimprovagt
core dumps, so I need to investigate further and ask to
please hold off until I figure out the reason. Thanks!
I found investigating cimprovagt to be very painful, hence the reason
why I redid 1-15 a bit. I'd suggest trying to apply 1-3 first - make
sure they work. Then 4-13 to make sure they work. Then go slower on
14-20. I found that 14/15 were the most problematic... 16-18 were
mechanical. 19 seemed to be harmless; however, who knows.
The issue with 14/15 was that CIM_RES_TYPE_UNKNOWN already existed and
was in use for other things - that's why I added UNKDEV, although I
could have messed the numbering scheme up. I know there are specific
rules about what numbers can be used, but I'm not sure of the details...
John