On 06/28/2013 04:46 AM, Xu Wang wrote:
Now system_has_kvm() would check all type value of domain label in caps. If any of them type is "kvm", system_has_kvm() return 1 as true result.
Signed-off-by: Xu Wang <cngesaint@gmail.com> --- libxkutil/device_parsing.c | 13 +++++-------- libxkutil/device_parsing.h | 2 +- src/Virt_VirtualSystemManagementService.c | 7 +------ 3 files changed, 7 insertions(+), 15 deletions(-)
OK, this works for me. Maybe one last nit ...
-int parse_domain_type(xmlNodePtr node, char **value) +int parse_domain_type(xmlNodePtr node) ... since the function is now checking for the existence of KVM domains in the capabilities XML, it should probably be renamed to something more adequate, like has_kvm_domain(..) or similar.
-- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294