δΊ 2013-3-22 7:16, John Ferlan ει:
On 03/20/2013 11:46 PM, Wenchao Xia wrote:
Hi, John These were recoded patches, removing script for bridge patch is removed, please add yours after it. After reconsideration, I think we should stick to libvirt 0.9.0 for libvirt-cim0.6.2, which makes 0.6.2 as steady version and allow user to update to it without any trouble. After it we can raise the libvirt version requirement in config file. Also please add signed-off in your patches.
Many thanks.
I'll repost the bridge patch tomorrow at some point.
As for 0.9.0 vs. later - I understand your position, maybe there's some other mechanism that would allow the "choice" for someone to build using a later version that would allow the use of those All API's. What I Possiblely a macro or condition in configure could do it, but I'd like leave the work to be done later.
don't know/understand is when libvirt-cim is built, is a 0.9.0 environment used? Not that it should matter, but I guess I'm just curious. no need to be 0.9.0, my env is 0.9.4 on RH6.3. I remember RH6.2 have a lower libvirt version and some user used it.
For those patches I had questions/issues with - just post an update and let's take it from there. I don't think you have to repost the whole series unless that's what DV would prefer.
I think repost full serial will make patch review/pick easier, we can make sure correct right version will be picked as a complete serial, the changes will be mentioned in the cover-letter so reviewer can skip unchanged patches.
I'm not sure what you mean by "add signed-off in your patches". I'm still a bit of a novice w/ git and the process.
when commit, use command 'git commit -s FILE -m COMMENT' will add this line, which declare the author of it.
John
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Best Regards Wenchao Xia