Re: [Libvirt-cim] [PATCH 1 of 3] Cleanup device_type_from_poolid() in DevicePool

KR> The change to "from_str()" here is so that one would be able to KR> pass the classname in. The logic for determining the device / KR> pool type is the same for the InstanceID and the classname. Right, but we could potentially need to look at more of the ID in some cases to determine the type, right? If we had disk pools that represent LVMs separately from file images or something like that. I suppose it's reasonable to think that the classname would always indicate the subtype, but it just seems cleaner to me to always do it From an ID. We can adjust it later if we come across this situation, I just thought it was worth considering. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com