libvirt-cim-bounces@redhat.com wrote on 2009-01-14 04:53:32:
Deepti B Kalakeri wrote:
You need to do these changes on top of "#2 Update RASD-05_disk_rasd_emu_type.py to support Xen, skip adding CDROM devices while emu_type=1" or else kaitlin needs to add this before she applies "#2 Update RASD-05_disk_rasd_emu_type.py to support Xen, skip adding CDROM devices while emu_type=1" patch to the tree.
I agree. In these kinds of cases, the patch is generally resent to include the new changes instead of generating a second patch.
There can be exceptions if a patch is particularly long or if it easier to read if it is broken up.
However, both patches looked good to me and both are applied.
Thanks! I will merge those two patches and resent in these kinds of cases next time.
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim