KR> This is terribly nit-picky.. but why use variables for ns and cn? KR> They only get used once in this function, right? I suppose it KR> does look cleaner though. It is just to clean up the function calls. Also, in lots of these functions, there are already lines that depend on something like 'ns' being passed in, so just setting ns to what it was before reduces the likelihood of breaking something that depends on such semantics. Given how fast I'm going through these, breaking fewer things is a good thing, I think. We do the "const char *ns = NAMESPACE(ref)" thing in lots of other places and it just "feels right" for some reason, but if people disagree and want to set a policy about it, that's fine with me. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com