libvirt-cim-bounces@redhat.com wrote on 2009-01-09 18:31:43:
+1 for me, but see the comments inline below:
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1231210158 28800 # Node ID b592961ccaac67ad3cfd8876beb22beec0c28492 # Parent 64b84ef28b22d17dd22027c632a9dc44d642d2b5 [TEST] #7 Add new test to verify enum of DiskRASD to have EmulatedType=0 for Disk and EmulatedType=1 for CDROM
Updates form 6 to 7: Correct exception description
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
+ + emu_types = [0, 1] + try: + for exp_emu_type in emu_types: + cxml = get_class(options.virt)(default_dom, emu_type=exp_emu_type)
When you update the test case for Xen and other virt types, can you change the above to the following : virt_xml = get_class(options.virt)
cxml = virt_xml(default_dom, emu_type=exp_emu_type)
Good catch. This sounds good to me. I will update it later. Thanks!
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim