Re: [Libvirt-cim] [PATCH] (#2) [RFC] Add Virt_ComputerSystemModifiedIndication, which watches for changes in our guests
Jay Gagnon wrote:
# HG changeset patch
# User Jay Gagnon <grendel(a)linux.vnet.ibm.com>
# Date 1200339496 18000
# Node ID 83dd6d18f98c2f43b59cbed5e025969f94a43f84
# Parent 51c57a6dabe9068f8638a6b923779085ff98b67e
(#2) [RFC] Add Virt_ComputerSystemModifiedIndication, which watches for changes in our
guests.
Changes since last time:
change free_dom_xml from int to void return type
use *far* better sys_name_from_xml logic
use calloc instead of malloc for allocating array
get UUID for domain directly into dom_xml structure
changed struct dom_xml's uuid member to suit
get xml for domain directly into dom_xml structure
add cleanup_domain_list function
use ObjectPath from CIMOM for prefix, classname, etc instead of literals
Signed-off-by: Jay Gagnon <grendel(a)linux.vnet.ibm.com>
If everyone is okay with things I will be integrating this into the
existing CS indication provider (although codewise it might really be
more like the other way around). If there is anything major here then I
can do one more round of RFC before I integrate, but any minor things
will be handled along with the integration.
Oh, and just as a matter of taste, I prefer (#2) over .#2 as a method of
comment protection in the commit message. Opinions?
--
-Jay