Re: [Libvirt-cim] [PATCH] libxutil: Fix memory device dumpCore field parsing
于 2014年06月12日 02:53, John Ferlan 写道:
On 06/04/2014 10:06 PM, Xu Wang wrote:
> Signed-off-by: Xu Wang <gesaint(a)linux.vnet.ibm.com>
> ---
> libxkutil/device_parsing.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Do you mind if I merge/squash this together with your other dumpCore patch?
John
Sure. Thanks for your work.
Xu Wang
> diff --git a/libxkutil/device_parsing.c b/libxkutil/device_parsing.c
> index d654a6a..815feea 100644
> --- a/libxkutil/device_parsing.c
> +++ b/libxkutil/device_parsing.c
> @@ -850,9 +850,9 @@ static int parse_mem_device(xmlNode *node, struct virt_device
**vdevs)
> else if (XSTREQ(node->name, "memory")) {
> sscanf(content, "%" PRIu64, &mdev->maxsize);
> tmpval = get_attr_value(node, "dumpCore");
> - if (tmpval && XSTREQ(tmpval, "on")) {
> + if (tmpval && STREQC(tmpval, "on")) {
> mdev->dumpCore = MEM_DUMP_CORE_ON;
> - } else if (tmpval && XSTREQ(content, "off")) {
> + } else if (tmpval && STREQC(tmpval, "off")) {
> mdev->dumpCore = MEM_DUMP_CORE_OFF;
> } else {
> mdev->dumpCore = MEM_DUMP_CORE_NOT_SET;
>
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim