δΊ 2013-3-22 0:51, John Ferlan ει:
On 03/20/2013 11:39 PM, Wenchao Xia wrote:
This property is used but not defined, so add it.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- schema/Virt_VSSD.mof | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/schema/Virt_VSSD.mof b/schema/Virt_VSSD.mof index baf4ac2..b960450 100644 --- a/schema/Virt_VSSD.mof +++ b/schema/Virt_VSSD.mof @@ -27,4 +27,7 @@ class Virt_VirtualSystemSettingData : CIM_VirtualSystemSettingData [Description ("Flag to determine whether this guest has to be autostarted on reboot")] uint16 AutoStart;
+ [Description ("Flag to determine whether this guest is a full virtualization")] + boolean IsFullVirt; + };
This property is found in 'VSSD.mof':
class Xen_VirtualSystemSettingData : Virt_VirtualSystemSettingData {
[Description ("Flag to determine whether this guest is fully-virtualized")] boolean IsFullVirt; ...
Since that is a child of the one you are placing the the property into, shouldn't it be removed from the child?
I found this property is used for KVM/Xen, no LXC, so I guess adding it in KVM_VSSD in VSSD.mof is a better way. I'll change it in next version. Note there is a bug like code in vssd_to_domain(), which treat this property as a condition before entering child class property retrieving. It is why I added it in parent class before.
Also I think the Description in VSSD.mof is better than the one in Virt_VSSD.mof.
John
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Best Regards Wenchao Xia