Re: [Libvirt-cim] [PATCH] [CU][RFC] Correct a few API issues
Dan Smith wrote:
# HG changeset patch
# User Dan Smith <danms(a)us.ibm.com>
# Date 1196124861 28800
# Node ID 96b651213e50f02586988064a014bbe746dc9c59
# Parent 05f120725e3dc562dc8fa251da698faa474f0b55
[CU][RFC] Correct a few API issues
that I think need to be resolved before we snap a release.
Some of the cu_get_* functions returned values instead of a CMPIrc's
like everything else, so this changes that.
A great change that makes the
functions very consistent now :).
Also, return const char *'s
from the broker memory so that the callers don't need to free the result.
Also a great change. This will really take away a lot of free's from the
providers.
This will require some work in libvirt-cim to make sure the new API
is
adhered to properly. If this is okay with people, I'll follow up with a
patch to libvirt-cim to make those changes. Any other discussion about
things that should change in the libcmpiutil API is welcomed.
Signed-off-by: Dan Smith <danms(a)us.ibm.com>
diff -r 05f120725e3d -r 96b651213e50 args_util.c
--- a/args_util.c Mon Nov 26 16:51:12 2007 -0800
+++ b/args_util.c Mon Nov 26 16:54:21 2007 -0800
@@ -32,28 +32,32 @@
#define CU_WEAK_TYPES 1
-char *cu_get_str_path(const CMPIObjectPath *reference, const char *key)
+CMPIrc cu_get_str_path(const CMPIObjectPath *ref,
+ const char *key,
+ const char **val)
{
The patch is rejected at the function above. All others applied fine.
--
Regards
Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor
heidieck(a)linux.vnet.ibm.com
**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294