3:19 p.m.
# HG changeset patch
# User Dan Smith <danms(a)us.ibm.com>
# Date 1194992297 28800
# Node ID d2bcdde08df6080caa9ae8d152d516d232fb6345
# Parent 1828b3b30fe476fbae1bf31d99c999ba548911f5
Fix RPM dependency in libvirt-cim
Having the sblim-cmpi-devel package installed actually breaks our binary
because the sblim broker function table (and many others, probably) does not
match what Pegasus uses, making binaries incompatible (which is very
disturbing).
I was getting a very strange indication trigger crash on F8 because the
invokeMethod broker function pointer was off-by-one.
Signed-off-by: Dan Smith <danms(a)us.ibm.com>
diff -r 1828b3b30fe4 -r d2bcdde08df6 libvirt-cim.spec.in
--- a/libvirt-cim.spec.in Tue Nov 13 11:39:22 2007 -0800
+++ b/libvirt-cim.spec.in Tue Nov 13 14:18:17 2007 -0800
@@ -11,11 +11,12 @@ URL: http://libvirt.org/CIM/
URL: http://libvirt.org/CIM/
Requires: libxml2
Requires: libvirt >= 0.2.3
-BuildRequires: sblim-cmpi-devel
+BuildRequires: tog-pegasus-devel
BuildRequires: libvirt-devel >= 0.2.3
BuildRequires: e2fsprogs-devel
BuildRequires: libxml2-devel
BuildRequires: libcmpiutil-devel
+BuildConflicts: sblim-cmpi-devel
%description
Libvirt-cim is a CMPI CIM provider that implements the DMTF SVPC
4:57 p.m.
Dan Smith wrote:
@@ -11,11 +11,12 @@ URL: http://libvirt.org/CIM/
URL: http://libvirt.org/CIM/
Requires: libxml2
Requires: libvirt >= 0.2.3
-BuildRequires: sblim-cmpi-devel
+BuildRequires: tog-pegasus-devel
BuildRequires: libvirt-devel >= 0.2.3
BuildRequires: e2fsprogs-devel
BuildRequires: libxml2-devel
BuildRequires: libcmpiutil-devel
+BuildConflicts: sblim-cmpi-devel
Is there a way to make this configurable for those that don't want to
use Pegasus? What if you're using Pegasus but you don't have
tog-pegasus installed (only sblim-cmpi-devel). Although, forcing
Pegasus users to use tog-pegasus-devel instead of sblim-cmpi-devel is
probably reasonable.
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com
5:26 p.m.
KR> Is there a way to make this configurable for those that don't want
KR> to use Pegasus?
This is only for the RPM, of course, and I'm aiming at the Fedora
environment. If any other platforms want to use this spec, then we
might need to tweak it, however, I'm not aware of any distros that
include sfcb.
KR> What if you're using Pegasus but you don't have tog-pegasus
KR> installed (only sblim-cmpi-devel).
If you're using Pegasus, have sblim-cmpi-devel installed, and try to
compile the provider (and libcmpiutil) against it, you'll generate
broken binaries. However, I don't think that people who have Pegasus
installed from source are likely to try to install/build this RPM, as
they would have to disable dependency checking.
KR> Although, forcing Pegasus users to use tog-pegasus-devel instead
KR> of sblim-cmpi-devel is probably reasonable.
In the context of a Fedora build, I think we need to explicitly mark
packages that will cause broken binaries to be build as Conflicts. We
could, however, make the .spec generated with the correct
Requires/Conflicts items based on what CIMOM you told configure to
use.
Perhaps someone more familiar with RPM building could step in here
with an authoritative answer.
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms(a)us.ibm.com
6249
days inactive
6249
days old
2 comments
2 participants
participants (2)
-
Dan Smith -
Kaitlin Rupert