Re: [Libvirt-cim] [PATCH 2 of 3] [TEST] KVMXML cim_define() support and KVM support for Profile.02
Kaitlin Rupert wrote:
--
- Zhengang
zli(a)linux.vnet.ibm.com wrote:
> # HG changeset patch
> # User Zhengang Li <lizg(a)cn.ibm.com>
> # Date 1208332735 -28800
> # Node ID 32614eca2a5579389cc5b262eff8243b0ca2da82
> # Parent 7c20d87e25c0cd53deba4dc8c48529d84bb740d9
> [TEST] KVMXML cim_define() support and KVM support for Profile.02
>
> Signed-off-by: Zhengang Li <lizg(a)cn.ibm.com>
>
> diff -r 7c20d87e25c0 -r 32614eca2a55
> suites/libvirt-cim/cimtest/Profile/02_profile_to_elec.py
This is a nice clean up and looks good to me. However, the test fails
due to the "Address field missing from vsms.py" issue Deepti noted in
her e-mail about Dan's emulator fix.
For the Address fix, we'll need conditional behavior based on the
changeset. So I'll hold off on applying this set.
I saw this patch when I was trying to update the cim_define() support
for KVM and others.
Is this still true that we'll need to do conditional behavior on
changeset?