Re: [Libvirt-cim] [PATCH 1 of 2] Add preliminary XML-parsing support for Xen FV domains
Dan Smith wrote:
+
+ printf("Type string: %s\n", dominfo->typestr);
This should probably be a CU_DEBUG() statement.
+
+ free(dom->os_info.pv.type);
+ if (dom->type == DOMAIN_XENPV) {
+ free(dom->os_info.pv.kernel);
+ free(dom->os_info.pv.initrd);
+ free(dom->os_info.pv.cmdline);
+ } else if (dom->type == DOMAIN_XENFV) {
+ free(dom->os_info.fv.loader);
+ free(dom->os_info.fv.boot);
+ } else {
+ CU_DEBUG("Unknown domain type %i", dom->type);
+ }
Does os_info.fv.type need to be freed as well?
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com