Re: [Libvirt-cim] [V3 PATCH 01/10] add source code of libbridge and libnl-3

On 01/13/2012 03:19 AM, Daniel Veillard wrote: > On Fri, Jan 13, 2012 at 09:45:47AM +0800, Wayne Xia wrote: >> 于 2012-1-13 7:16, Sharad Mishra 写道: >>> << snip>> >>> >>>> diff --git a/libnetwork/libbridge/libbridge.h b/libnetwork/ >>>> libbridge/libbridge.h >>>> new file mode 100644 >>>> index 0000000..39964f2 >>>> --- /dev/null >>>> +++ b/libnetwork/libbridge/libbridge.h >>>> @@ -0,0 +1,119 @@ >>>> +/* >>>> + * Copyright (C) 2000 Lennert Buytenhek >>> >>> Are you using an existing code written by above author? >>> If it is a new code then use - >>> >> codes in this patch are existing ones have no modification by me, I >> wonder whether moving source codes of these into libvirt-cim project >> is acceptable. > > In general that's not a good idea. > The problem is that if there is a security problem we need to fix the > original package and all the copies which were done in various projects. > Also such copied code tend to not be updated, makes it easier to bypass > APIs boundaries and becomes long term maintenance problems. > So unless said code is kind of confidential, i.e. not widely distributed > then that something to avoid really, > > Daniel > Also there is an issue with license. Libvirt-cim is LGPL while the code you copied is GPL. In this case all files that make use of those features should be relicensed as GPL as well. While I have no experience on this area, I guess it would be not receive the legal approval in the end.