12:52 a.m.
Hi,
When creating a dedicated storage pool on a FC attached storage with sector
size of 4096B and size of 2TB, the storage pool is created but reported as 1/8
of it's size, the same follows for any volume created in the same storage
pool:
# virsh pool-info guest_images_disk
Name: guest_images_disk
UUID: 30247222-c1fb-8749-b833-a73782198d26
State: running
Persistent: yes
Autostart: yes
Capacity: 256.00 GB
Allocation: 122.07 MB
Available: 255.88 GB
--
David Cohen
Grid Computing
Physics Department
Technion - Israel Institute of Technology
Phone: 972-4-8293668
Fax: 972-4-8295755
Cellular: 972-54-5385664
4:36 a.m.
On Tue, Aug 23, 2011 at 08:52:56AM +0300, David Cohen wrote:
Hi,
When creating a dedicated storage pool on a FC attached storage with sector
size of 4096B and size of 2TB, the storage pool is created but reported as 1/8
of it's size, the same follows for any volume created in the same storage
pool:
# virsh pool-info guest_images_disk
Name: guest_images_disk
UUID: 30247222-c1fb-8749-b833-a73782198d26
State: running
Persistent: yes
Autostart: yes
Capacity: 256.00 GB
Allocation: 122.07 MB
Available: 255.88 GB
What type of pool have you created. You mention FC, which makes me think
you have a SCSI pool type, but then I would expect 'Available' to always
be zero, so I guess it must be a different pool type. Can you show the
pool XML, and also the XML for one of the volumes within it.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
4:49 a.m.
Hi,
The xml file used to create the pool :
<pool type='disk'>
<name>guest_images_disk</name>
<source>
<device path='/dev/sdb'/>
<format type='gpt'/>
</source>
<target>
<path>/dev</path>
</target>
</pool>
virsh pool-dumpxml guest_images_disk
<pool type='disk'>
<name>guest_images_disk</name>
<uuid>30247222-c1fb-8749-b833-a73782198d26</uuid>
<capacity>274877904384</capacity>
<allocation>127997440</allocation>
<available>274749903872</available>
<source>
<device path='/dev/sdb'>
<freeExtent start='128000512' end='274877904384'/>
</device>
<format type='unknown'/>
</source>
<target>
<path>/dev</path>
<permissions>
<mode>0700</mode>
<owner>-1</owner>
<group>-1</group>
</permissions>
</target>
</pool>
virsh vol-dumpxml --pool guest_images_disk sdb1
<volume>
<name>sdb1</name>
<key>/dev/sdb1</key>
<source>
<device path='/dev/sdb'>
<extent start='3072' end='128000512'/>
</device>
</source>
<capacity>127997440</capacity>
<allocation>127997440</allocation>
<target>
<path>/dev/sdb1</path>
<format type='none'/>
<permissions>
<mode>0660</mode>
<owner>0</owner>
<group>6</group>
</permissions>
</target>
</volume>
David
On Tuesday 23 August 2011 12:36:10 Daniel P. Berrange wrote:
On Tue, Aug 23, 2011 at 08:52:56AM +0300, David Cohen wrote:
> Hi,
> When creating a dedicated storage pool on a FC attached storage with
> sector size of 4096B and size of 2TB, the storage pool is created but
> reported as 1/8 of it's size, the same follows for any volume created in
> the same storage pool:
>
>
> # virsh pool-info guest_images_disk
> Name: guest_images_disk
> UUID: 30247222-c1fb-8749-b833-a73782198d26
> State: running
> Persistent: yes
> Autostart: yes
> Capacity: 256.00 GB
> Allocation: 122.07 MB
> Available: 255.88 GB
What type of pool have you created. You mention FC, which makes me think
you have a SCSI pool type, but then I would expect 'Available' to always
be zero, so I guess it must be a different pool type. Can you show the
pool XML, and also the XML for one of the volumes within it.
Daniel
9:25 a.m.
On Tue, Aug 23, 2011 at 12:49:41PM +0300, David Cohen wrote:
Hi,
The xml file used to create the pool :
<pool type='disk'>
<name>guest_images_disk</name>
<source>
<device path='/dev/sdb'/>
<format type='gpt'/>
</source>
<target>
<path>/dev</path>
</target>
</pool>
Ok, it is a disk partition based pool. It appears that our parted
code is assuming 512 byte sectors as you thought. I reckon that
this change should fix it
diff --git a/src/storage/parthelper.c b/src/storage/parthelper.c
index acc9171..964aa78 100644
--- a/src/storage/parthelper.c
+++ b/src/storage/parthelper.c
@@ -157,17 +157,17 @@ int main(int argc, char **argv)
part->num, '\0',
type, '\0',
content, '\0',
- part->geom.start * 512llu, '\0',
- (part->geom.end + 1 ) * 512llu, '\0',
- part->geom.length * 512llu, '\0');
+ part->geom.start * dev->sector_size, '\0',
+ (part->geom.end + 1 ) * dev->sector_size, '\0',
+ part->geom.length * dev->sector_size, '\0');
} else {
printf("%s%c%s%c%s%c%llu%c%llu%c%llu%c",
"-", '\0',
type, '\0',
content, '\0',
- part->geom.start * 512llu, '\0',
- (part->geom.end + 1 ) * 512llu, '\0',
- part->geom.length * 512llu, '\0');
+ part->geom.start * dev->sector_size, '\0',
+ (part->geom.end + 1 ) * dev->sector_size, '\0',
+ part->geom.length * dev->sector_size, '\0');
}
part = ped_disk_next_partition(disk, part);
}
but I don't have any way to test this myself
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
4873
days inactive
4873
days old
3 comments
2 participants
participants (2)
-
Daniel P. Berrange -
David Cohen