On Tue, Nov 30, 2021 at 11:06:27AM +0000, Daniel P. Berrangé wrote:
On Tue, Nov 30, 2021 at 02:40:07AM -0800, Andrea Bolognani wrote:
Michal, have you actually looked at the patch mentioned earlier? If not, you can perhaps do a clean room implementation of the fix based on the information provided above and get us out of this stalemate?
It's quite a simple change, but having seen the original patch I feel like I couldn't possibly submit it myself and still be in the clear.
We're over thinking things here. The way this change is implemented is the only way anyone would write this code, and is a simple cut+paste from the code pattern in the lines above so arguably already a derived work. This is not a bit of code that meets the criteria to taint you from a copyright POV.
I just implemented & posted the obvious fix in virArch and it is identical to the patch referenced earlier in this thread, rather proving my point.
I trust your judgement on this, hence my R-b :) Thanks! -- Andrea Bolognani / Red Hat / Virtualization