[libvirt] [PATCH] tests: run schema checks in sorted order
Having a test that depends on file system timestamps and/or inode allocation order is non-deterministic in its output. * tests/schematestutils.sh: Run test in deterministic order. --- Pushing under the trivial rule. Evidence of the non-determinism can be found at the location of the three failures reported here: https://www.redhat.com/archives/libvir-list/2011-December/msg00908.html tests/schematestutils.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index f2b3b50..ec6452a 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -13,7 +13,7 @@ for dir in $DIRS do XML=`find $abs_srcdir/$dir -name '*.xml'` || exit 1 - for xml in $XML + for xml in `echo $XML | sort` do n=`expr $n + 1` cmd="xmllint --relaxng $SCHEMA --noout $xml" -- 1.7.7.4
Commit 6fdbce12 attempted to sort the list of tests, but failed (without quotes, echo merges all the tests into a single line, so there was nothing to sort). * tests/schematestutils.sh: Fix thinko in previous patch. --- Pushing under the trivial rule. /me pulls brown paper bag over face - so much for being known as a shell expert :) tests/schematestutils.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index ec6452a..4361221 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -13,7 +13,7 @@ for dir in $DIRS do XML=`find $abs_srcdir/$dir -name '*.xml'` || exit 1 - for xml in `echo $XML | sort` + for xml in `echo "$XML" | sort` do n=`expr $n + 1` cmd="xmllint --relaxng $SCHEMA --noout $xml" -- 1.7.7.4
participants (1)
-
Eric Blake