[Libvir] PATCH: Fix remote driver SSH tunnelling
An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[] Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Daniel P. Berrange wrote:
An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[]
ACK. I just noticed the same problem. -Ryan
Dan.
------------------------------------------------------------------------
-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Daniel P. Berrange wrote:
An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[]
Strange, I wonder when that happened ... I was using an ssh tunnel only the other day. ACK. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Tue, Jan 15, 2008 at 09:31:28AM +0000, Richard W.M. Jones wrote:
Daniel P. Berrange wrote:
An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[]
Strange, I wonder when that happened ... I was using an ssh tunnel only the other day.
Yeah, I use it quite often too - guess I was unlucky and always using the SSH tunnelling on boxes with the Fedora libvirt RPMs, rather than on my dev boxes with CVS libvirt. Anyway, now committed. When DV returns we should probably aim to put out a 0.4.1 release because there have been a number of annoying bugs in 0.4.0 which we've sorted out. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (3)
-
Daniel P. Berrange -
Richard W.M. Jones -
Ryan Scott