[Libvir] Re: [et-mgmt-tools] ANNOUNCE: virt-viewer release 0.0.1
On Fri, Aug 17, 2007 at 04:10:52PM +0200, Gerd Hoffmann wrote:
Hi,
To connect to the guest with ID 7 running under QEMU
virt-viewer --connect qemu:///system 7
Can we *please* think about a standardized environment variable to set the default for --connect and which all tools are looking at?
Yes, this would be useful.
virsh has VIRSH_DEFAULT_CONNECT_URI for that.
I'd like to have *one* variable used by *all* libvirt-based tools, virt-viewer, virt-manager, virsh, ... We could simply reuse the virsh variable, or we could pick some other name without virsh in there, preferable also shorter and thus easier to remember. VIRT_URI maybe?
We should probably apply the change to libvirt, so that if 'NULL' is used for the connect URI for virConnectOpen, and VIRT_CONNECT_URI is set, then NULL gets substituted with the value of the env variable. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Fri, Aug 17, 2007 at 03:13:13PM +0100, Daniel P. Berrange wrote:
On Fri, Aug 17, 2007 at 04:10:52PM +0200, Gerd Hoffmann wrote:
Hi,
To connect to the guest with ID 7 running under QEMU
virt-viewer --connect qemu:///system 7
Can we *please* think about a standardized environment variable to set the default for --connect and which all tools are looking at?
Yes, this would be useful.
virsh has VIRSH_DEFAULT_CONNECT_URI for that.
I'd like to have *one* variable used by *all* libvirt-based tools, virt-viewer, virt-manager, virsh, ... We could simply reuse the virsh variable, or we could pick some other name without virsh in there, preferable also shorter and thus easier to remember. VIRT_URI maybe?
We should probably apply the change to libvirt, so that if 'NULL' is used for the connect URI for virConnectOpen, and VIRT_CONNECT_URI is set, then NULL gets substituted with the value of the env variable.
Yup that sounds reasonnable, we should update the documentation too in that case, but sounds fine to me, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Daniel P. Berrange wrote:
On Fri, Aug 17, 2007 at 04:10:52PM +0200, Gerd Hoffmann wrote:
Hi,
To connect to the guest with ID 7 running under QEMU
virt-viewer --connect qemu:///system 7 Can we *please* think about a standardized environment variable to set the default for --connect and which all tools are looking at?
Yes, this would be useful.
virsh has VIRSH_DEFAULT_CONNECT_URI for that.
I'd like to have *one* variable used by *all* libvirt-based tools, virt-viewer, virt-manager, virsh, ... We could simply reuse the virsh variable, or we could pick some other name without virsh in there, preferable also shorter and thus easier to remember. VIRT_URI maybe?
We should probably apply the change to libvirt, so that if 'NULL' is used for the connect URI for virConnectOpen, and VIRT_CONNECT_URI is set, then NULL gets substituted with the value of the env variable.
Very good idea. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
Gerd Hoffmann -
Richard W.M. Jones