[libvirt] PATCH: Fix virsh reporting open errors

The error handling refactor we did in virsh a few months back, accidentally means we never report the real libvirt error message for the initial connection attempt. This patch fixes it Daniel Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.202 diff -u -p -r1.202 virsh.c --- src/virsh.c 28 Apr 2009 10:55:45 -0000 1.202 +++ src/virsh.c 8 May 2009 16:36:30 -0000 @@ -6876,6 +6876,7 @@ vshInit(vshControl *ctl) * such as "help". */ if (!ctl->conn) { + virshReportError(ctl); vshError(ctl, FALSE, "%s", _("failed to connect to the hypervisor")); return FALSE; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

On Fri, May 08, 2009 at 05:42:59PM +0100, Daniel P. Berrange wrote:
The error handling refactor we did in virsh a few months back, accidentally means we never report the real libvirt error message for the initial connection attempt. This patch fixes it
Sure, ACK ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (2)
-
Daniel P. Berrange
-
Daniel Veillard