[libvirt] [PATCHv2] test: Disable storage test when FS backend isn't compiled in

'virstoragetest' accesses backing chains of files on local storage with the help of the storage driver. Disable the test on builds without the storage driver as the test is crashing otherwise. Reported by: Roman Bogorodskiy --- Notes: Version 2: - Don't run the test from the makefile instead of adding code that might not compile cleanly tests/Makefile.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index c999061..2f762a6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -285,10 +285,13 @@ test_programs += nwfilterxml2firewalltest endif WITH_NWFILTER if WITH_STORAGE -test_programs += storagevolxml2argvtest \ - virstoragetest +test_programs += storagevolxml2argvtest endif WITH_STORAGE +if WITH_STORAGE_FS +test_programs += virstoragetest +endif + if WITH_LINUX test_programs += virscsitest endif WITH_LINUX -- 1.9.3

On Mon, Jun 23, 2014 at 13:21:49 +0200, Peter Krempa wrote:
'virstoragetest' accesses backing chains of files on local storage with the help of the storage driver. Disable the test on builds without the storage driver as the test is crashing otherwise.
Reported by: Roman Bogorodskiy ---
Notes: Version 2: - Don't run the test from the makefile instead of adding code that might not compile cleanly
Looks better, ACK. Jirka

On 06/23/14 13:31, Jiri Denemark wrote:
On Mon, Jun 23, 2014 at 13:21:49 +0200, Peter Krempa wrote:
'virstoragetest' accesses backing chains of files on local storage with the help of the storage driver. Disable the test on builds without the storage driver as the test is crashing otherwise.
Reported by: Roman Bogorodskiy ---
Notes: Version 2: - Don't run the test from the makefile instead of adding code that might not compile cleanly
Looks better, ACK.
Pushed; Thanks. Peter
participants (2)
-
Jiri Denemark
-
Peter Krempa