[libvirt] [PATCH 0/2] qemu: conf: Fix memory leaks
Peter Krempa (2): qemu: conf: Don't leak snapshot image format conf variable qemu: conf: Don't leak 'namespaces' temporary variable while parsing config src/qemu/qemu_conf.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.12.2
==20406== 4 bytes in 1 blocks are definitely lost in loss record 6 of 1,059 ==20406== at 0x4C2AF3F: malloc (vg_replace_malloc.c:299) ==20406== by 0x8F17D39: strdup (in /lib64/libc-2.24.so) ==20406== by 0x552C0E0: virStrdup (virstring.c:784) ==20406== by 0x54D3622: virConfGetValueString (virconf.c:945) ==20406== by 0x144E4692: virQEMUDriverConfigLoadFile (qemu_conf.c:687) ==20406== by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) ==20406== by 0x55DB585: virStateInitialize (libvirt.c:770) ==20406== by 0x124570: daemonRunStateInit (libvirtd.c:881) ==20406== by 0x5532990: virThreadHelper (virthread.c:206) ==20406== by 0x8C82493: start_thread (in /lib64/libpthread-2.24.so) ==20406== by 0x8F7FA1E: clone (in /lib64/libc-2.24.so) --- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 3b33e37bb..132ee664a 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -407,6 +407,7 @@ static void virQEMUDriverConfigDispose(void *obj) VIR_FREE(cfg->saveImageFormat); VIR_FREE(cfg->dumpImageFormat); + VIR_FREE(cfg->snapshotImageFormat); VIR_FREE(cfg->autoDumpPath); virStringListFree(cfg->securityDriverNames); -- 2.12.2
==20406== 8 bytes in 1 blocks are definitely lost in loss record 24 of 1,059 ==20406== at 0x4C2CF55: calloc (vg_replace_malloc.c:711) ==20406== by 0x54BF530: virAllocN (viralloc.c:191) ==20406== by 0x54D37C4: virConfGetValueStringList (virconf.c:1001) ==20406== by 0x144E4E8E: virQEMUDriverConfigLoadFile (qemu_conf.c:835) ==20406== by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) ==20406== by 0x55DB585: virStateInitialize (libvirt.c:770) ==20406== by 0x124570: daemonRunStateInit (libvirtd.c:881) ==20406== by 0x5532990: virThreadHelper (virthread.c:206) ==20406== by 0x8C82493: start_thread (in /lib64/libpthread-2.24.so) ==20406== by 0x8F7FA1E: clone (in /lib64/libc-2.24.so) --- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 132ee664a..1b704daa5 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -877,6 +877,7 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg, ret = 0; cleanup: + virStringListFree(namespaces); virStringListFree(controllers); virStringListFree(hugetlbfs); virStringListFree(nvram); -- 2.12.2
On Wed, Apr 12, 2017 at 02:55:51PM +0200, Peter Krempa wrote:
Peter Krempa (2): qemu: conf: Don't leak snapshot image format conf variable qemu: conf: Don't leak 'namespaces' temporary variable while parsing config
src/qemu/qemu_conf.c | 2 ++ 1 file changed, 2 insertions(+)
ACK series. Jan
participants (2)
-
Ján Tomko -
Peter Krempa