[libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize
This work was motivated by Dan's intention to introduce the keycodemapdb module into libvirt[1]. As it is, we have a few useful submodule-related features in our build system, but they are limited in that they assume there will be a single submodule, and it will be gnulib. This series removes such assumptions, making it possible to introduce more submodules without having to sacrifice any convenience. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html Andrea Bolognani (2): autogen.sh: Rewrite autogen.sh: Modularize .gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++ autogen.sh | 286 +++++++++++++++++++++++++++++-------------- cfg.mk | 34 ++--- 4 files changed, 265 insertions(+), 122 deletions(-) create mode 100644 .submodules/gnulib.functions -- 2.7.4
The goal is twofold: firstly, we want to be able to make parts of it into reusable modules, and secondly we'd like to reduce the amount of duplicated code. Moreover, since we're making heavy changes to the code anyway, we might as well make sure it follows a somewhat consistent coding style too. To reduce code duplication, we introduce a new --dry-run option, which can be used by third parties to figure out whether calling autogen.sh is necessary or not: this allows us to get rid of the reimplementation of part of the logic in cfg.mk and guarantee they'll never get out of sync. In order to be able to move forward with modularization down the line, we extract the gnulib-specific part of the submodule logic into three functions which adhere to a fairly generic API that's not tied to gnulib. Other changes include: removing assumptions about gnulib being the only submodule, both in actual logic and in messages to the user; making dirty submodules checking and cleaning entirely independent of whether or not updating submodules is needed; removing the use of 'set -e' and handling errors explicitly instead. --- I originally intended to proceed with this rewrite through a series of small, incremental changes; however, I soon realized it would take a lot more time and energy, and the result will be in some case quite frankly silly, so I've decided to go with a single commit that includes an extensive explanation of goals and changes. Basically: the diff is useless, just look at the two scripts side by side ;) The shell code is probably not 100% portable to all weird platforms out there (the use of 'local' comes to mind), but it should be portable enough to work on all those we target with libvirt. I've tested it on Fedora 24, CentOS 6 and FreeBSD 11 without running into any issue. autogen.sh | 269 +++++++++++++++++++++++++++++++++++++++++-------------------- cfg.mk | 34 ++------ 2 files changed, 189 insertions(+), 114 deletions(-) diff --git a/autogen.sh b/autogen.sh index d1c319d..98baab7 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,117 +1,210 @@ #!/bin/sh # Run this to generate all the initial makefiles, etc. -set -e +die() +{ + echo "error: $1" >&2 + exit 1 +} -srcdir=`dirname "$0"` -test -z "$srcdir" && srcdir=. +starting_point=$(pwd) -THEDIR=`pwd` -cd "$srcdir" +srcdir=$(dirname "$0") +test "$srcdir" || srcdir=. -test -f src/libvirt.c || { - echo "You must run this script in the top-level libvirt directory" - exit 1 +cd "$srcdir" || { + die "failed to cd into $srcdir" } +test -f src/libvirt.c || { + die "$0 must live in the top-level libvirt directory" +} -EXTRA_ARGS= +dry_run= no_git= -if test "x$1" = "x--no-git"; then - no_git=" $1" - shift - case "$1 $2" in - --gnulib-srcdir=*) no_git="$no_git $1"; shift ;; - --gnulib-srcdir\ *) no_git="$no_git $1=$2"; shift; shift;; - esac -fi -if test -z "$NOCONFIGURE" ; then - if test "x$1" = "x--system"; then - shift - prefix=/usr - libdir=$prefix/lib - sysconfdir=/etc - localstatedir=/var - if [ -d /usr/lib64 ]; then - libdir=$prefix/lib64 - fi - EXTRA_ARGS="--prefix=$prefix --sysconfdir=$sysconfdir --localstatedir=$localstatedir --libdir=$libdir" - echo "Running ./configure with $EXTRA_ARGS $@" - else - if test -z "$*" && test ! -f "$THEDIR/config.status"; then - echo "I am going to run ./configure with no arguments - if you wish" - echo "to pass any to it, please specify them on the $0 command line." - fi - fi -fi +gnulib_srcdir= +extra_args= +while test "$#" -gt 0; do + case "$1" in + --dry-run) + # This variable will serve both as an indicator of the fact that a + # dry run has been requested, and to store the result of the dry run. + # It will be ultimately used as return code for the script, so a + # value of 1 means "running autogen.sh is not needed at this time" + dry_run=1 + shift + ;; + --no-git) + no_git=" $1" + shift + ;; + --gnulib-srcdir=*) + gnulib_srcdir=" $1" + shift + ;; + --gnulib-srcdir) + gnulib_srcdir=" $1=$2" + shift + shift + ;; + --system) + prefix=/usr + sysconfdir=/etc + localstatedir=/var + if test -d $prefix/lib64; then + libdir=$prefix/lib64 + else + libdir=$prefix/lib + fi + extra_args="--prefix=$prefix --localstatedir=$localstatedir" + extra_args="$extra_args --sysconfdir=$sysconfdir --libdir=$libdir" + shift + ;; + *) + # All remaining arguments will be passed to configure verbatim + break + ;; + esac +done +no_git="$no_git$gnulib_srcdir" -# Compute the hash we'll use to determine whether rerunning bootstrap -# is required. The first is just the SHA1 that selects a gnulib snapshot. -# The second ensures that whenever we change the set of gnulib modules used -# by this package, we rerun bootstrap to pull in the matching set of files. -# The third ensures that whenever we change the set of local gnulib diffs, -# we rerun bootstrap to pull in those diffs. -bootstrap_hash() +gnulib_hash() { + local no_git=$1 + if test "$no_git"; then - echo no-git + echo "no-git" return fi - git submodule status | sed 's/^[ +-]//;s/ .*//' + + # Compute the hash we'll use to determine whether rerunning bootstrap + # is required. The first is just the SHA1 that selects a gnulib snapshot. + # The second ensures that whenever we change the set of gnulib modules used + # by this package, we rerun bootstrap to pull in the matching set of files. + # The third ensures that whenever we change the set of local gnulib diffs, + # we rerun bootstrap to pull in those diffs. + git submodule status .gnulib | awk '{ print $1 }' git hash-object bootstrap.conf - git ls-tree -d HEAD gnulib/local | awk '{print $3}' + git ls-tree -d HEAD gnulib/local | awk '{ print $3 }' } -# Ensure that whenever we pull in a gnulib update or otherwise change to a -# different version (i.e., when switching branches), we also rerun ./bootstrap. -# Also, running 'make rpm' tends to litter the po/ directory, and some people -# like to run 'git clean -x -f po' to fix it; but only ./bootstrap regenerates -# the required file po/Makevars. -# Only run bootstrap from a git checkout, never from a tarball. -if test -d .git || test -f .git; then - curr_status=.git-module-status t= - if test "$no_git"; then - t=no-git - elif test -d .gnulib; then - t=$(bootstrap_hash; git diff .gnulib) +gnulib_update_required() +{ + local expected=$1 + local actual=$2 + local no_git=$3 + + local ret=0 + + # Whenever the gnulib submodule or any of the related bits has been + # changed in some way (see gnulib_hash) we need to update the submodule, + # eg. run bootstrap again; updating is also needed if any of the files + # that can only be generated through bootstrap has gone missing + if test "$actual" = "$expected" && \ + test -f po/Makevars && test -f AUTHORS; then + ret=1 fi - case $t:${CLEAN_SUBMODULE+set} in - *:set) ;; - *-dirty*) - echo "error: gnulib submodule is dirty, please investigate" 2>&1 - echo "set env-var CLEAN_SUBMODULE to discard gnulib changes" 2>&1 - exit 1 ;; - esac - # Keep this test in sync with cfg.mk:_update_required - if test "$t" = "$(cat $curr_status 2>/dev/null)" \ - && test -f "po/Makevars" && test -f AUTHORS; then - # good, it's up to date, all we need is autoreconf - autoreconf -if + + return "$ret" +} + +gnulib_update() +{ + local expected=$1 + local actual=$2 + local no_git=$3 + + local ret=0 + + # Depending on whether or not an update is required, we might be able to + # get away with simply running autoreconf, or we might have to go through + # the bootstrap process + if gnulib_update_required "$expected" "$actual" "$no_git"; then + echo "Running bootstrap..." + ./bootstrap$no_git --bootstrap-sync + ret=$? else - if test -z "$no_git" && test ${CLEAN_SUBMODULE+set}; then - echo cleaning up submodules... - git submodule foreach 'git clean -dfqx && git reset --hard' + echo "Running autoreconf..." + autoreconf -if + ret=$? + fi + + return "$ret" +} + +if test -d .git || test -f .git; then + + if test -z "$CLEAN_SUBMODULE"; then + git submodule status | while read _ path _; do + dirty=$(git diff "$path") + case "$dirty" in + *-dirty*) + echo "error: $path is dirty, please investigate" >&2 + echo "set CLEAN_SUBMODULE to discard submodule changes" >&2 + exit 1 + ;; + esac + done + fi + if test "$CLEAN_SUBMODULE" && test -z "$no_git"; then + if test -z "$dry_run"; then + echo "Cleaning up submodules..." + git submodule foreach 'git clean -dfqx && git reset --hard' || { + die "cleaning up submodules failed" + } + fi + fi + + curr_status=.git-module-status + expected=$(cat "$curr_status" 2>/dev/null) + actual=$(gnulib_hash "$no_git") + + if test "$dry_run"; then + if gnulib_update_required "$expected" "$actual" "$no_git"; then + dry_run=0 fi - echo running bootstrap$no_git... - ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ - || { echo "Failed to bootstrap, please investigate."; exit 1; } + else + gnulib_update "$expected" "$actual" "$no_git" || { + die "submodule update failed" + } + gnulib_hash >"$curr_status" fi fi -test -n "$NOCONFIGURE" && exit 0 +# When performing a dry run, we can stop here +test "$dry_run" && exit "$dry_run" -cd "$THEDIR" +# If asked not to run configure, we can stop here +test "$NOCONFIGURE" && exit 0 -if test "x$OBJ_DIR" != x; then - mkdir -p "$OBJ_DIR" - cd "$OBJ_DIR" +cd "$starting_point" || { + die "failed to cd into $starting_point" +} + +if test "$OBJ_DIR"; then + mkdir -p "$OBJ_DIR" || { + die "failed to create $OBJ_DIR" + } + cd "$OBJ_DIR" || { + die "failed to cd into $OBJ_DIR" + } fi -if test -z "$*" && test -z "$EXTRA_ARGS" && test -f config.status; then - ./config.status --recheck +if test -z "$*" && test -z "$extra_args" && test -f config.status; then + ./config.status --recheck || { + die "config.status failed" + } else - $srcdir/configure $EXTRA_ARGS "$@" -fi && { - echo - echo "Now type 'make' to compile libvirt." -} + if test -z "$*" && test -z "$extra_args"; then + echo "I am going to run ./configure with no arguments - if you wish" + echo "to pass any to it, please specify them on the $0 command line." + else + echo "Running ./configure with $extra_args $@" + fi + $srcdir/configure $extra_args "$@" || { + die "configure failed" + } +fi + +echo +echo "Now type 'make' to compile libvirt." diff --git a/cfg.mk b/cfg.mk index 4c22195..c40e7b4 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1026,33 +1026,15 @@ prev_version_file = /dev/null ifneq ($(_gl-Makefile),) ifeq (0,$(MAKELEVEL)) - _curr_status = .git-module-status - # The sed filter accommodates those who check out on a commit from which - # no tag is reachable. In that case, git submodule status prints a "-" - # in column 1 and does not print a "git describe"-style string after the - # submodule name. Contrast these: - # -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib - # b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib (v0.0-2286-gb653eda) - # $ cat .git-module-status - # b653eda3ac4864de205419d9f41eec267cb89eeb - # - # Keep this logic in sync with autogen.sh. - _submodule_hash = $(SED) 's/^[ +-]//;s/ .*//' - _update_required := $(shell \ - cd '$(srcdir)'; \ - test -d .git || { echo 0; exit; }; \ - test -f po/Makevars || { echo 1; exit; }; \ - test -f AUTHORS || { echo 1; exit; }; \ - test "no-git" = "$$(cat $(_curr_status))" && { echo 0; exit; }; \ - actual=$$(git submodule status | $(_submodule_hash); \ - git hash-object bootstrap.conf; \ - git ls-tree -d HEAD gnulib/local | awk '{print $$3}'; \ - git diff .gnulib); \ - stamp="$$($(_submodule_hash) $(_curr_status) 2>/dev/null)"; \ - test "$$stamp" = "$$actual"; echo $$?) + _autogen_required := $(shell \ + cd '$(srcdir)'; \ + test -d .git || test -f .git || { echo 0; exit; }; \ + $(srcdir)/autogen.sh --dry-run >/dev/null 2>&1 || { echo 0; exit; }; \ + echo 1; \ + ) _clean_requested = $(filter %clean,$(MAKECMDGOALS)) - ifeq (1,$(_update_required)$(_clean_requested)) - $(info INFO: gnulib update required; running ./autogen.sh first) + ifeq (1,$(_autogen_required)$(_clean_requested)) + $(info INFO: running autogen.sh is required, running it now...) $(shell touch $(srcdir)/AUTHORS $(srcdir)/ChangeLog) maint.mk Makefile: _autogen endif -- 2.7.4
This sets up a generic framework for dealing with git submodules, removing the assumption that gnulib is going to be the only git submodule libvirt uses and making it relatively easy for more to be added without sacrificing the convenience we've gotten used to, eg. automatic updates. --- .gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++++++++++ autogen.sh | 155 ++++++++++++++++++++++--------------------- 3 files changed, 145 insertions(+), 77 deletions(-) create mode 100644 .submodules/gnulib.functions diff --git a/.gitignore b/.gitignore index d7927e1..f1ca602 100644 --- a/.gitignore +++ b/.gitignore @@ -30,11 +30,11 @@ .dirstamp .gdb_history .git -.git-module-status .libs .lvimrc .memdump .sc-start-sc_* +.submodules/*.status /ABOUT-NLS /AUTHORS /ChangeLog diff --git a/.submodules/gnulib.functions b/.submodules/gnulib.functions new file mode 100644 index 0000000..ec89b37 --- /dev/null +++ b/.submodules/gnulib.functions @@ -0,0 +1,65 @@ +gnulib_hash() +{ + local no_git=$1 + + if test "$no_git"; then + echo "no-git" + return + fi + + # Compute the hash we'll use to determine whether rerunning bootstrap + # is required. The first is just the SHA1 that selects a gnulib snapshot. + # The second ensures that whenever we change the set of gnulib modules used + # by this package, we rerun bootstrap to pull in the matching set of files. + # The third ensures that whenever we change the set of local gnulib diffs, + # we rerun bootstrap to pull in those diffs. + git submodule status .gnulib | awk '{ print $1 }' + git hash-object bootstrap.conf + git ls-tree -d HEAD gnulib/local | awk '{ print $3 }' +} + +gnulib_update_required() +{ + local expected=$1 + local actual=$2 + local no_git=$3 + + local ret=0 + + # Whenever the gnulib submodule or any of the related bits has been + # changed in some way (see gnulib_hash) we need to update the submodule, + # eg. run bootstrap again; updating is also needed if any of the files + # that can only be generated through bootstrap has gone missing + if test "$actual" = "$expected" && \ + test -f po/Makevars && test -f AUTHORS; then + ret=1 + fi + + return "$ret" +} + +gnulib_update() +{ + local expected=$1 + local actual=$2 + local no_git=$3 + + local ret=0 + + # Depending on whether or not an update is required, we might be able to + # get away with simply running autoreconf, or we might have to go through + # the bootstrap process + if gnulib_update_required "$expected" "$actual" "$no_git"; then + echo "Running bootstrap..." + ./bootstrap$no_git --bootstrap-sync + ret=$? + else + echo "Running autoreconf..." + autoreconf -if + ret=$? + fi + + return "$ret" +} + +# vim: set syntax=sh: diff --git a/autogen.sh b/autogen.sh index 98baab7..38b3476 100755 --- a/autogen.sh +++ b/autogen.sh @@ -7,6 +7,19 @@ die() exit 1 } +git_submodules() +{ + # Print the list of known submodules. Parse the .gitmodules file because + # we want the submodule's alias rather than its path (as we're going to + # use it for building eg. function names) and the 'git submodule' command + # doesn't provide us with that information + grep -E '^\[submodule ' .gitmodules | while read _ name; do + name=${name#\"} + name=${name%%\"*} + echo "$name" + done +} + starting_point=$(pwd) srcdir=$(dirname "$0") @@ -68,70 +81,6 @@ while test "$#" -gt 0; do done no_git="$no_git$gnulib_srcdir" -gnulib_hash() -{ - local no_git=$1 - - if test "$no_git"; then - echo "no-git" - return - fi - - # Compute the hash we'll use to determine whether rerunning bootstrap - # is required. The first is just the SHA1 that selects a gnulib snapshot. - # The second ensures that whenever we change the set of gnulib modules used - # by this package, we rerun bootstrap to pull in the matching set of files. - # The third ensures that whenever we change the set of local gnulib diffs, - # we rerun bootstrap to pull in those diffs. - git submodule status .gnulib | awk '{ print $1 }' - git hash-object bootstrap.conf - git ls-tree -d HEAD gnulib/local | awk '{ print $3 }' -} - -gnulib_update_required() -{ - local expected=$1 - local actual=$2 - local no_git=$3 - - local ret=0 - - # Whenever the gnulib submodule or any of the related bits has been - # changed in some way (see gnulib_hash) we need to update the submodule, - # eg. run bootstrap again; updating is also needed if any of the files - # that can only be generated through bootstrap has gone missing - if test "$actual" = "$expected" && \ - test -f po/Makevars && test -f AUTHORS; then - ret=1 - fi - - return "$ret" -} - -gnulib_update() -{ - local expected=$1 - local actual=$2 - local no_git=$3 - - local ret=0 - - # Depending on whether or not an update is required, we might be able to - # get away with simply running autoreconf, or we might have to go through - # the bootstrap process - if gnulib_update_required "$expected" "$actual" "$no_git"; then - echo "Running bootstrap..." - ./bootstrap$no_git --bootstrap-sync - ret=$? - else - echo "Running autoreconf..." - autoreconf -if - ret=$? - fi - - return "$ret" -} - if test -d .git || test -f .git; then if test -z "$CLEAN_SUBMODULE"; then @@ -155,20 +104,74 @@ if test -d .git || test -f .git; then fi fi - curr_status=.git-module-status - expected=$(cat "$curr_status" 2>/dev/null) - actual=$(gnulib_hash "$no_git") + for submodule in $(git_submodules); do + functions_file=".submodules/$submodule.functions" + status_file=".submodules/$submodule.status" + + # No need to check for the file's existence: the script will + # abort if it's not present + . "$functions_file" + + # hash_function(no_git): + # @no_git: whether to avoid using git for updates + # + # This function must print a hash encompassing the entire submodule + # status. The hash will be remembered between runs and will be used + # to determine whether a submodule update is required. + # + # Output: submodule hash + # Return value: ignored + hash_function="${submodule}_hash" + type "$hash_function" >/dev/null 2>&1 || { + die "required function $hash_function missing" + } - if test "$dry_run"; then - if gnulib_update_required "$expected" "$actual" "$no_git"; then - dry_run=0 - fi - else - gnulib_update "$expected" "$actual" "$no_git" || { - die "submodule update failed" + # update_required_function(expected, actual, no_git): + # @expected: expected hash (from previous run) + # @actual: actual hash (from current run) + # @no_git: whether to avoid using git for updates + # + # This function is used to determine whether a submodule update is + # required. It must perform no action, regardless of the outcome: + # it's mostly intended for use with --dry-run. + # + # Output: ignored + # Return value: 0 if update is required, 1 otherwise + update_required_function="${submodule}_update_required" + type "$update_required_function" >/dev/null 2>&1 || { + die "required function $update_required_function missing" } - gnulib_hash >"$curr_status" - fi + + # update_function(expected, actual, no_git): + # @expected: expected hash (from previous run) + # @actual: actual hash (from current run) + # @no_git: whether to avoid using git for updates + # + # This function must perform the submodule update; if no update + # is required, it can decide to skip it, but it will be called + # regardless. + # + # Output: ignored + # Return value: 0 if update was successful, 1 otherwise + update_function="${submodule}_update" + type "$update_function" >/dev/null 2>&1 || { + die "required function $update_function missing" + } + + expected=$(cat "$status_file" 2>/dev/null) + actual=$("$hash_function" "$no_git") + + if test "$dry_run"; then + if "$update_required_function" "$expected" "$actual" "$no_git"; then + dry_run=0 + fi + else + "$update_function" "$expected" "$actual" "$no_git" || { + die "submodule update failed" + } + "$hash_function" >"$status_file" + fi + done fi # When performing a dry run, we can stop here -- 2.7.4
On Tue, 2017-04-18 at 16:31 +0200, Andrea Bolognani wrote:
This sets up a generic framework for dealing with git submodules, removing the assumption that gnulib is going to be the only git submodule libvirt uses and making it relatively easy for more to be added without sacrificing the convenience we've gotten used to, eg. automatic updates.
This should be squashed in so that we ship all the files required to regenerate the build system: diff --git a/Makefile.am b/Makefile.am index 333ec5a..df0c851 100644 --- a/Makefile.am +++ b/Makefile.am @@ -38,6 +38,7 @@ EXTRA_DIST = \ libvirt-admin.pc.in \ Makefile.nonreentrant \ autogen.sh \ + .submodules/gnulib.functions \ cfg.mk \ run.in \ AUTHORS.in -- Andrea Bolognani / Red Hat / Virtualization
On Tue, Apr 18, 2017 at 04:31:16PM +0200, Andrea Bolognani wrote:
This work was motivated by Dan's intention to introduce the keycodemapdb module into libvirt[1]. As it is, we have a few useful submodule-related features in our build system, but they are limited in that they assume there will be a single submodule, and it will be gnulib.
What is it that makes out submodule handling so complicated. eg in gtk-vnc and spice-gtk, we have a trivial line in autogen.sh 'git submodule update --init --recursive' that takes care of it. Is all the complexity we see caused by the need to detect when to re-run bootstrap for gnulib ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote:
What is it that makes out submodule handling so complicated. eg in gtk-vnc and spice-gtk, we have a trivial line in autogen.sh 'git submodule update --init --recursive' that takes care of it. Is all the complexity we see caused by the need to detect when to re-run bootstrap for gnulib ?
Pretty much, yeah. -- Andrea Bolognani / Red Hat / Virtualization
On Wed, Apr 19, 2017 at 09:02:50AM +0200, Andrea Bolognani wrote:
On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote:
What is it that makes out submodule handling so complicated. eg in gtk-vnc and spice-gtk, we have a trivial line in autogen.sh 'git submodule update --init --recursive' that takes care of it. Is all the complexity we see caused by the need to detect when to re-run bootstrap for gnulib ?
Pretty much, yeah.
This still feels over-engineered to me. I don't really see the benefit in creating modular files like .submodules/keycodemapdb.functions - it is a generic facility that is unlikely to ever be needed by anything other than gnulib. It feels like we ought to be able to just have the general purpose submodule update as above, and then just decide if we need to rerun bootstrap after that Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, 2017-04-19 at 10:06 +0100, Daniel P. Berrange wrote:
This still feels over-engineered to me. I don't really see the benefit in creating modular files like .submodules/keycodemapdb.functions - it is a generic facility that is unlikely to ever be needed by anything other than gnulib.
It feels like we ought to be able to just have the general purpose submodule update as above, and then just decide if we need to rerun bootstrap after that
I'll try to come up with something :) -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Daniel P. Berrange