[libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart
There are three spapces for a indent every line in the function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 86e82d6..bed8edb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -420,28 +420,28 @@ static void qemuDomainNetsRestart(void *payload, const void *name ATTRIBUTE_UNUSED, void *data ATTRIBUTE_UNUSED) { - int i; - virDomainObjPtr vm = (virDomainObjPtr)payload; - virDomainDefPtr def = vm->def; - - virDomainObjLock(vm); - - for (i = 0; i < def->nnets; i++) { - virDomainNetDefPtr net = def->nets[i]; - if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT && - virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { - VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", - net->ifname, def->name); - ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, - net->mac, - virDomainNetGetActualDirectDev(net), - def->uuid, - virDomainNetGetActualVirtPortProfile(net), - VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); - } - } + int i; + virDomainObjPtr vm = (virDomainObjPtr)payload; + virDomainDefPtr def = vm->def; + + virDomainObjLock(vm); - virDomainObjUnlock(vm); + for (i = 0; i < def->nnets; i++) { + virDomainNetDefPtr net = def->nets[i]; + if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT && + virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { + VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", + net->ifname, def->name); + ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, + net->mac, + virDomainNetGetActualDirectDev(net), + def->uuid, + virDomainNetGetActualVirtPortProfile(net), + VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); + } + } + + virDomainObjUnlock(vm); } /** -- 1.7.9.5
On 2012年05月03日 13:52, Li Zhang wrote:
There are three spapces for a indent every line in the
s/spapces/spaces/
function qemuDomainNetsRestart.
This patch is to correct it.
Signed-off-by: Li Zhang<zhlcindy@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 86e82d6..bed8edb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -420,28 +420,28 @@ static void qemuDomainNetsRestart(void *payload, const void *name ATTRIBUTE_UNUSED, void *data ATTRIBUTE_UNUSED) { - int i; - virDomainObjPtr vm = (virDomainObjPtr)payload; - virDomainDefPtr def = vm->def; - - virDomainObjLock(vm); - - for (i = 0; i< def->nnets; i++) { - virDomainNetDefPtr net = def->nets[i]; - if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& - virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { - VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", - net->ifname, def->name); - ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, - net->mac, - virDomainNetGetActualDirectDev(net), - def->uuid, - virDomainNetGetActualVirtPortProfile(net), - VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); - } - } + int i; + virDomainObjPtr vm = (virDomainObjPtr)payload; + virDomainDefPtr def = vm->def; + + virDomainObjLock(vm);
- virDomainObjUnlock(vm); + for (i = 0; i< def->nnets; i++) { + virDomainNetDefPtr net = def->nets[i]; + if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& + virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { + VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", + net->ifname, def->name); + ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, + net->mac, + virDomainNetGetActualDirectDev(net), + def->uuid, + virDomainNetGetActualVirtPortProfile(net), + VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); + } + } + + virDomainObjUnlock(vm); }
/**
ACK, and pushed with the commit message a bit improved. Osier
On 05/03/2012 05:25 PM, Osier Yang wrote:
On 2012年05月03日 13:52, Li Zhang wrote:
There are three spapces for a indent every line in the
s/spapces/spaces/
function qemuDomainNetsRestart.
This patch is to correct it.
Signed-off-by: Li Zhang<zhlcindy@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 86e82d6..bed8edb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -420,28 +420,28 @@ static void qemuDomainNetsRestart(void *payload, const void *name ATTRIBUTE_UNUSED, void *data ATTRIBUTE_UNUSED) { - int i; - virDomainObjPtr vm = (virDomainObjPtr)payload; - virDomainDefPtr def = vm->def; - - virDomainObjLock(vm); - - for (i = 0; i< def->nnets; i++) { - virDomainNetDefPtr net = def->nets[i]; - if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& - virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { - VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", - net->ifname, def->name); - ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, - net->mac, - virDomainNetGetActualDirectDev(net), - def->uuid, - virDomainNetGetActualVirtPortProfile(net), - VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); - } - } + int i; + virDomainObjPtr vm = (virDomainObjPtr)payload; + virDomainDefPtr def = vm->def; + + virDomainObjLock(vm);
- virDomainObjUnlock(vm); + for (i = 0; i< def->nnets; i++) { + virDomainNetDefPtr net = def->nets[i]; + if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& + virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { + VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", + net->ifname, def->name); + ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, + net->mac, + virDomainNetGetActualDirectDev(net), + def->uuid, + virDomainNetGetActualVirtPortProfile(net), + VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); + } + } + + virDomainObjUnlock(vm); }
/**
ACK, and pushed with the commit message a bit improved. https://www.redhat.com/archives/libvir-list/2012-May/msg00211.html
Osier
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 05/03/2012 05:25 PM, Osier Yang wrote:
On 2012年05月03日 13:52, Li Zhang wrote:
There are three spapces for a indent every line in the
s/spapces/spaces/
function qemuDomainNetsRestart.
This patch is to correct it.
Signed-off-by: Li Zhang<zhlcindy@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 86e82d6..bed8edb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -420,28 +420,28 @@ static void qemuDomainNetsRestart(void *payload, const void *name ATTRIBUTE_UNUSED, void *data ATTRIBUTE_UNUSED) { - int i; - virDomainObjPtr vm = (virDomainObjPtr)payload; - virDomainDefPtr def = vm->def; - - virDomainObjLock(vm); - - for (i = 0; i< def->nnets; i++) { - virDomainNetDefPtr net = def->nets[i]; - if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& - virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { - VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", - net->ifname, def->name); - ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, - net->mac, - virDomainNetGetActualDirectDev(net), - def->uuid, - virDomainNetGetActualVirtPortProfile(net), - VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); - } - } + int i; + virDomainObjPtr vm = (virDomainObjPtr)payload; + virDomainDefPtr def = vm->def; + + virDomainObjLock(vm);
- virDomainObjUnlock(vm); + for (i = 0; i< def->nnets; i++) { + virDomainNetDefPtr net = def->nets[i]; + if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT&& + virDomainNetGetActualDirectMode(net) == VIR_NETDEV_MACVLAN_MODE_VEPA) { + VIR_DEBUG("VEPA mode device %s active in domain %s. Reassociating.", + net->ifname, def->name); + ignore_value(virNetDevMacVLanRestartWithVPortProfile(net->ifname, + net->mac, + virDomainNetGetActualDirectDev(net), + def->uuid, + virDomainNetGetActualVirtPortProfile(net), + VIR_NETDEV_VPORT_PROFILE_OP_CREATE)); + } + } + + virDomainObjUnlock(vm); }
/**
ACK, and pushed with the commit message a bit improved.
Got it, thanks. :)
Osier
-- Best Regards Li IBM LTC, China System&Technology Lab, Beijing
participants (3)
-
Alex Jia -
Li Zhang -
Osier Yang