[libvirt] [PATCH] virstoragefile: identify GPFS as cluster FS

GPFS is 'IBM General Parallel File System', also called 'IBM Spectrum Scale', stalls when a process issues a lot of fsyncs in a short timeframe. It is better if the VM I/O is not synchronous. It is racommended to use writeback caching policy. In order to permit that it is added VIR_FILE_SHFS_GPFS to the list of shared file systems in virStorageFileIsClusterFS function. Signed-off-by: Diego Michelotto <diego.michelotto@cnaf.infn.it> --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b2e308d81d..0fe2819dc6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1349,7 +1349,8 @@ int virStorageFileIsClusterFS(const char *path) return virFileIsSharedFSType(path, VIR_FILE_SHFS_GFS2 | VIR_FILE_SHFS_OCFS | - VIR_FILE_SHFS_CEPH); + VIR_FILE_SHFS_CEPH | + VIR_FILE_SHFS_GPFS); } #ifdef LVS -- 2.20.1

HI all, any news about this patch? All the best. Diego Michelotto +------------------------------------+ - uff: 051 2095493 - skype: diego-mikel8 +------------------------------------+
Il giorno 27 feb 2019, alle ore 15:07, Diego Michelotto <diego.michelotto@cnaf.infn.it> ha scritto:
GPFS is 'IBM General Parallel File System', also called 'IBM Spectrum Scale', stalls when a process issues a lot of fsyncs in a short timeframe.
It is better if the VM I/O is not synchronous. It is racommended to use writeback caching policy.
In order to permit that it is added VIR_FILE_SHFS_GPFS to the list of shared file systems in virStorageFileIsClusterFS function.
Signed-off-by: Diego Michelotto <diego.michelotto@cnaf.infn.it> --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b2e308d81d..0fe2819dc6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1349,7 +1349,8 @@ int virStorageFileIsClusterFS(const char *path) return virFileIsSharedFSType(path, VIR_FILE_SHFS_GFS2 | VIR_FILE_SHFS_OCFS | - VIR_FILE_SHFS_CEPH); + VIR_FILE_SHFS_CEPH | + VIR_FILE_SHFS_GPFS); }
#ifdef LVS -- 2.20.1

On 2/27/19 3:07 PM, Diego Michelotto wrote:
GPFS is 'IBM General Parallel File System', also called 'IBM Spectrum Scale', stalls when a process issues a lot of fsyncs in a short timeframe.
It is better if the VM I/O is not synchronous. It is racommended to use writeback caching policy.
Using writeback may lead to a data loss if qemu is killed on destination and underlying FS has not synced the data. Since I don't have GPFS I can't confirm it's behaving safely on migration. And I wasn't fortunate finding that on the internet either. Michal
participants (2)
-
Diego Michelotto
-
Michal Privoznik