[libvirt] [PATCH 0/4] python: add some missing python bindings
Hi all, This patchset adds some missing python bindings. The bindings for the following APIs are added: - virDomainGetSchedulerParametersFlags - virDomainSetSchedulerParametersFlags - virDomainPinVcpusFlags - virDomainGetVcpuPinInfo *[PATCH 1/3] python: add Python binding for virDomainGetSchedulerParametersFlags API *[PATCH 2/3] python: add Python binding for virDomainSetSchedulerParametersFlags API *[PATCH 3/3] python: add Python binding for virDomainPinVcpusFlags API *[PATCH 4/4] python: add Python binding for virDomainGetVcpuPinInfo API Best regards, Taku Izumi -- Taku Izumi <izumi.taku@jp.fujitsu.com>
This patch adds the Python bindings for virDomainGetSchedulerParametersFlags API. Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- python/libvirt-override-api.xml | 6 ++ python/libvirt-override.c | 83 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) Index: libvirt/python/libvirt-override-api.xml =================================================================== --- libvirt.orig/python/libvirt-override-api.xml +++ libvirt/python/libvirt-override-api.xml @@ -151,6 +151,12 @@ <return type='int' info='-1 in case of error, 0 in case of success.'/> <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> </function> + <function name='virDomainGetSchedulerParametersFlags' file='python'> + <info>Get the scheduler parameters</info> + <return type='virSchedParameterPtr' info='None in case of error, returns a dictionary of params'/> + <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> + <arg name='flags' type='int' info='an OR'ed set of virDomainModificationImpact'/> + </function> <function name='virDomainGetSchedulerType' file='python'> <info>Get the scheduler type.</info> <return type='char *' info='NULL in case of error. The caller must free the returned string.'/> Index: libvirt/python/libvirt-override.c =================================================================== --- libvirt.orig/python/libvirt-override.c +++ libvirt/python/libvirt-override.c @@ -291,6 +291,88 @@ libvirt_virDomainGetSchedulerParameters( } static PyObject * +libvirt_virDomainGetSchedulerParametersFlags(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + virDomainPtr domain; + PyObject *pyobj_domain, *info; + char *c_retval; + int i_retval; + int nparams, i; + int flags; + virTypedParameterPtr params; + + if (!PyArg_ParseTuple(args, (char *)"Oi:virDomainGetScedulerParametersFlags", + &pyobj_domain, &flags)) + return(NULL); + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetSchedulerType(domain, &nparams); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval == NULL) + return VIR_PY_NONE; + free(c_retval); + + if ((params = malloc(sizeof(*params)*nparams)) == NULL) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetSchedulerParametersFlags(domain, params, &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (i_retval < 0) { + free(params); + return VIR_PY_NONE; + } + + /* convert to a Python tuple of long objects */ + if ((info = PyDict_New()) == NULL) { + free(params); + return VIR_PY_NONE; + } + for (i = 0 ; i < nparams ; i++) { + PyObject *key, *val; + + switch (params[i].type) { + case VIR_TYPED_PARAM_INT: + val = PyInt_FromLong((long)params[i].value.i); + break; + + case VIR_TYPED_PARAM_UINT: + val = PyInt_FromLong((long)params[i].value.ui); + break; + + case VIR_TYPED_PARAM_LLONG: + val = PyLong_FromLongLong((long long)params[i].value.l); + break; + + case VIR_TYPED_PARAM_ULLONG: + val = PyLong_FromLongLong((long long)params[i].value.ul); + break; + + case VIR_TYPED_PARAM_DOUBLE: + val = PyFloat_FromDouble((double)params[i].value.d); + break; + + case VIR_TYPED_PARAM_BOOLEAN: + val = PyBool_FromLong((long)params[i].value.b); + break; + + default: + free(params); + Py_DECREF(info); + return VIR_PY_NONE; + } + + key = libvirt_constcharPtrWrap(params[i].field); + PyDict_SetItem(info, key, val); + } + free(params); + return(info); +} + +static PyObject * libvirt_virDomainSetSchedulerParameters(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { virDomainPtr domain; @@ -3833,6 +3915,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virNodeGetCellsFreeMemory", libvirt_virNodeGetCellsFreeMemory, METH_VARARGS, NULL}, {(char *) "virDomainGetSchedulerType", libvirt_virDomainGetSchedulerType, METH_VARARGS, NULL}, {(char *) "virDomainGetSchedulerParameters", libvirt_virDomainGetSchedulerParameters, METH_VARARGS, NULL}, + {(char *) "virDomainGetSchedulerParametersFlags", libvirt_virDomainGetSchedulerParametersFlags, METH_VARARGS, NULL}, {(char *) "virDomainSetSchedulerParameters", libvirt_virDomainSetSchedulerParameters, METH_VARARGS, NULL}, {(char *) "virDomainSetBlkioParameters", libvirt_virDomainSetBlkioParameters, METH_VARARGS, NULL}, {(char *) "virDomainGetBlkioParameters", libvirt_virDomainGetBlkioParameters, METH_VARARGS, NULL},
On Fri, Jul 22, 2011 at 02:11:55PM +0900, Taku Izumi wrote:
This patch adds the Python bindings for virDomainGetSchedulerParametersFlags API.
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- python/libvirt-override-api.xml | 6 ++ python/libvirt-override.c | 83 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+)
Index: libvirt/python/libvirt-override-api.xml =================================================================== --- libvirt.orig/python/libvirt-override-api.xml +++ libvirt/python/libvirt-override-api.xml @@ -151,6 +151,12 @@ <return type='int' info='-1 in case of error, 0 in case of success.'/> <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> </function> + <function name='virDomainGetSchedulerParametersFlags' file='python'> + <info>Get the scheduler parameters</info> + <return type='virSchedParameterPtr' info='None in case of error, returns a dictionary of params'/> + <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> + <arg name='flags' type='int' info='an OR'ed set of virDomainModificationImpact'/> + </function> <function name='virDomainGetSchedulerType' file='python'> <info>Get the scheduler type.</info> <return type='char *' info='NULL in case of error. The caller must free the returned string.'/> Index: libvirt/python/libvirt-override.c =================================================================== --- libvirt.orig/python/libvirt-override.c +++ libvirt/python/libvirt-override.c @@ -291,6 +291,88 @@ libvirt_virDomainGetSchedulerParameters( }
static PyObject * +libvirt_virDomainGetSchedulerParametersFlags(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + virDomainPtr domain; + PyObject *pyobj_domain, *info; + char *c_retval; + int i_retval; + int nparams, i; + int flags;
flags are always unsigned int, but that's a minor change !
+ virTypedParameterPtr params; + + if (!PyArg_ParseTuple(args, (char *)"Oi:virDomainGetScedulerParametersFlags", + &pyobj_domain, &flags)) + return(NULL); + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetSchedulerType(domain, &nparams); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval == NULL) + return VIR_PY_NONE; + free(c_retval); + + if ((params = malloc(sizeof(*params)*nparams)) == NULL) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetSchedulerParametersFlags(domain, params, &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (i_retval < 0) { + free(params); + return VIR_PY_NONE; + } + + /* convert to a Python tuple of long objects */ + if ((info = PyDict_New()) == NULL) { + free(params); + return VIR_PY_NONE; + } + for (i = 0 ; i < nparams ; i++) { + PyObject *key, *val; + + switch (params[i].type) { + case VIR_TYPED_PARAM_INT: + val = PyInt_FromLong((long)params[i].value.i); + break; + + case VIR_TYPED_PARAM_UINT: + val = PyInt_FromLong((long)params[i].value.ui); + break; + + case VIR_TYPED_PARAM_LLONG: + val = PyLong_FromLongLong((long long)params[i].value.l); + break; + + case VIR_TYPED_PARAM_ULLONG: + val = PyLong_FromLongLong((long long)params[i].value.ul); + break; + + case VIR_TYPED_PARAM_DOUBLE: + val = PyFloat_FromDouble((double)params[i].value.d); + break; + + case VIR_TYPED_PARAM_BOOLEAN: + val = PyBool_FromLong((long)params[i].value.b); + break; + + default: + free(params); + Py_DECREF(info); + return VIR_PY_NONE; + } + + key = libvirt_constcharPtrWrap(params[i].field); + PyDict_SetItem(info, key, val); + } + free(params); + return(info); +} + +static PyObject * libvirt_virDomainSetSchedulerParameters(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { virDomainPtr domain; @@ -3833,6 +3915,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virNodeGetCellsFreeMemory", libvirt_virNodeGetCellsFreeMemory, METH_VARARGS, NULL}, {(char *) "virDomainGetSchedulerType", libvirt_virDomainGetSchedulerType, METH_VARARGS, NULL}, {(char *) "virDomainGetSchedulerParameters", libvirt_virDomainGetSchedulerParameters, METH_VARARGS, NULL}, + {(char *) "virDomainGetSchedulerParametersFlags", libvirt_virDomainGetSchedulerParametersFlags, METH_VARARGS, NULL}, {(char *) "virDomainSetSchedulerParameters", libvirt_virDomainSetSchedulerParameters, METH_VARARGS, NULL}, {(char *) "virDomainSetBlkioParameters", libvirt_virDomainSetBlkioParameters, METH_VARARGS, NULL}, {(char *) "virDomainGetBlkioParameters", libvirt_virDomainGetBlkioParameters, METH_VARARGS, NULL},
Looks fine, ACK, I will push this thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
This patch adds the Python bindings for virDomainSetSchedulerParametersFlags API. Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- python/libvirt-override-api.xml | 7 ++ python/libvirt-override.c | 96 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+) Index: libvirt/python/libvirt-override.c =================================================================== --- libvirt.orig/python/libvirt-override.c +++ libvirt/python/libvirt-override.c @@ -467,7 +467,102 @@ libvirt_virDomainSetSchedulerParameters( return VIR_PY_INT_SUCCESS; } +static PyObject * +libvirt_virDomainSetSchedulerParametersFlags(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + virDomainPtr domain; + PyObject *pyobj_domain, *info; + char *c_retval; + int i_retval; + int nparams, i; + int flags; + virTypedParameterPtr params; + + if (!PyArg_ParseTuple(args, + (char *)"OOi:virDomainSetScedulerParametersFlags", + &pyobj_domain, &info, &flags)) + return(NULL); + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetSchedulerType(domain, &nparams); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval == NULL) + return VIR_PY_INT_FAIL; + free(c_retval); + + if ((params = malloc(sizeof(*params)*nparams)) == NULL) + return VIR_PY_INT_FAIL; + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetSchedulerParametersFlags(domain, params, &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) { + free(params); + return VIR_PY_INT_FAIL; + } + + /* convert to a Python tuple of long objects */ + for (i = 0; i < nparams; i++) { + PyObject *key, *val; + key = libvirt_constcharPtrWrap(params[i].field); + val = PyDict_GetItem(info, key); + Py_DECREF(key); + + if (val == NULL) + continue; + + switch (params[i].type) { + case VIR_TYPED_PARAM_INT: + params[i].value.i = (int)PyInt_AS_LONG(val); + break; + + case VIR_TYPED_PARAM_UINT: + params[i].value.ui = (unsigned int)PyInt_AS_LONG(val); + break; + + case VIR_TYPED_PARAM_LLONG: + params[i].value.l = (long long)PyLong_AsLongLong(val); + break; + + case VIR_TYPED_PARAM_ULLONG: + params[i].value.ul = (unsigned long long)PyLong_AsLongLong(val); + break; + + case VIR_TYPED_PARAM_DOUBLE: + params[i].value.d = (double)PyFloat_AsDouble(val); + break; + + case VIR_TYPED_PARAM_BOOLEAN: + { + /* Hack - Python's definition of Py_True breaks strict + * aliasing rules, so can't directly compare :-( + */ + PyObject *hacktrue = PyBool_FromLong(1); + params[i].value.b = hacktrue == val ? 1: 0; + Py_DECREF(hacktrue); + } + break; + + default: + free(params); + return VIR_PY_INT_FAIL; + } + } + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainSetSchedulerParametersFlags(domain, params, nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) { + free(params); + return VIR_PY_INT_FAIL; + } + + free(params); + return VIR_PY_INT_SUCCESS; +} /* FIXME: This is a place holder for the implementation. */ @@ -3917,6 +4012,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetSchedulerParameters", libvirt_virDomainGetSchedulerParameters, METH_VARARGS, NULL}, {(char *) "virDomainGetSchedulerParametersFlags", libvirt_virDomainGetSchedulerParametersFlags, METH_VARARGS, NULL}, {(char *) "virDomainSetSchedulerParameters", libvirt_virDomainSetSchedulerParameters, METH_VARARGS, NULL}, + {(char *) "virDomainSetSchedulerParametersFlags", libvirt_virDomainSetSchedulerParametersFlags, METH_VARARGS, NULL}, {(char *) "virDomainSetBlkioParameters", libvirt_virDomainSetBlkioParameters, METH_VARARGS, NULL}, {(char *) "virDomainGetBlkioParameters", libvirt_virDomainGetBlkioParameters, METH_VARARGS, NULL}, {(char *) "virDomainSetMemoryParameters", libvirt_virDomainSetMemoryParameters, METH_VARARGS, NULL}, Index: libvirt/python/libvirt-override-api.xml =================================================================== --- libvirt.orig/python/libvirt-override-api.xml +++ libvirt/python/libvirt-override-api.xml @@ -180,6 +180,13 @@ <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> <arg name='params' type='virSchedParameterPtr' info='pointer to scheduler parameter objects'/> </function> + <function name='virDomainSetSchedulerParametersFlags' file='python'> + <info>Change the scheduler parameters</info> + <return type='int' info='-1 in case of error, 0 in case of success.'/> + <arg name='domain' type='virDomainPtr' info='pointer to domain object'/> + <arg name='params' type='virSchedParameterPtr' info='pointer to scheduler parameter objects'/> + <arg name='flags' type='int' info='an OR'ed set of virDomainModificationImpact'/> + </function> <function name='virDomainSetBlkioParameters' file='python'> <info>Change the blkio tunables</info> <return type='int' info='-1 in case of error, 0 in case of success.'/>
This patch adds the Python bindings for virDomainPinVcpuFlags API. Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- python/generator.py | 1 python/libvirt-override-api.xml | 8 ++++++ python/libvirt-override.c | 48 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 57 insertions(+) Index: libvirt/python/libvirt-override-api.xml =================================================================== --- libvirt.orig/python/libvirt-override-api.xml +++ libvirt/python/libvirt-override-api.xml @@ -174,6 +174,14 @@ <arg name='vcpu' type='unsigned int' info='virtual CPU number'/> <arg name='cpumap' type='unsigned char *' info='pointer to a bit map of real CPUs (in 8-bit bytes) (IN) Each bit set to 1 means that corresponding CPU is usable. Bytes are stored in little-endian order: CPU0-7, 8-15... In each byte, lowest CPU number is least significant bit.'/> </function> + <function name='virDomainPinVcpuFlags' file='python'> + <info>Dynamically change the real CPUs which can be allocated to a virtual CPU. This function requires privileged access to the hypervisor.</info> + <return type='int' info='0 in case of success, -1 in case of failure.'/> + <arg name='domain' type='virDomainPtr' info='pointer to domain object, or NULL for Domain0'/> + <arg name='vcpu' type='unsigned int' info='virtual CPU number'/> + <arg name='cpumap' type='unsigned char *' info='pointer to a bit map of real CPUs (in 8-bit bytes) (IN) Each bit set to 1 means that corresponding CPU is usable. Bytes are stored in little-endian order: CPU0-7, 8-15... In each byte, lowest CPU number is least significant bit.'/> + <arg name='flags' type='int' info='flags to specify'/> + </function> <function name='virDomainSetSchedulerParameters' file='python'> <info>Change the scheduler parameters</info> <return type='int' info='-1 in case of error, 0 in case of success.'/> Index: libvirt/python/libvirt-override.c =================================================================== --- libvirt.orig/python/libvirt-override.c +++ libvirt/python/libvirt-override.c @@ -736,6 +736,53 @@ libvirt_virDomainPinVcpu(PyObject *self return VIR_PY_INT_SUCCESS; } +static PyObject * +libvirt_virDomainPinVcpuFlags(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + virDomainPtr domain; + PyObject *pyobj_domain, *pycpumap, *truth; + virNodeInfo nodeinfo; + unsigned char *cpumap; + int cpumaplen, i, vcpu; + int flags; + int i_retval; + + if (!PyArg_ParseTuple(args, (char *)"OiOi:virDomainPinVcpuFlags", + &pyobj_domain, &vcpu, &pycpumap, &flags)) + return(NULL); + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virNodeGetInfo(virDomainGetConnect(domain), &nodeinfo); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) + return VIR_PY_INT_FAIL; + + cpumaplen = VIR_CPU_MAPLEN(VIR_NODEINFO_MAXCPUS(nodeinfo)); + if ((cpumap = malloc(cpumaplen)) == NULL) + return VIR_PY_INT_FAIL; + memset(cpumap, 0, cpumaplen); + + truth = PyBool_FromLong(1); + for (i = 0 ; i < VIR_NODEINFO_MAXCPUS(nodeinfo) ; i++) { + PyObject *flag = PyTuple_GetItem(pycpumap, i); + if (flag == truth) + VIR_USE_CPU(cpumap, i); + else + VIR_UNUSE_CPU(cpumap, i); + } + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainPinVcpuFlags(domain, vcpu, cpumap, cpumaplen, flags); + LIBVIRT_END_ALLOW_THREADS; + Py_DECREF(truth); + free(cpumap); + + if (i_retval < 0) + return VIR_PY_INT_FAIL; + + return VIR_PY_INT_SUCCESS; +} /************************************************************************ * * @@ -4019,6 +4066,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetMemoryParameters", libvirt_virDomainGetMemoryParameters, METH_VARARGS, NULL}, {(char *) "virDomainGetVcpus", libvirt_virDomainGetVcpus, METH_VARARGS, NULL}, {(char *) "virDomainPinVcpu", libvirt_virDomainPinVcpu, METH_VARARGS, NULL}, + {(char *) "virDomainPinVcpuFlags", libvirt_virDomainPinVcpuFlags, METH_VARARGS, NULL}, {(char *) "virConnectListStoragePools", libvirt_virConnectListStoragePools, METH_VARARGS, NULL}, {(char *) "virConnectListDefinedStoragePools", libvirt_virConnectListDefinedStoragePools, METH_VARARGS, NULL}, {(char *) "virStoragePoolGetAutostart", libvirt_virStoragePoolGetAutostart, METH_VARARGS, NULL}, Index: libvirt/python/generator.py =================================================================== --- libvirt.orig/python/generator.py +++ libvirt/python/generator.py @@ -343,6 +343,7 @@ skip_impl = ( 'virDomainGetMemoryParameters', 'virDomainGetVcpus', 'virDomainPinVcpu', + 'virDomainPinVcpuFlags', 'virSecretGetValue', 'virSecretSetValue', 'virSecretGetUUID',
This patch adds the Python bindings for virDomainGetVcpuPinInfo API. Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- python/generator.py | 1 python/libvirt-override-api.xml | 6 +++ python/libvirt-override.c | 69 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 76 insertions(+) Index: libvirt/python/generator.py =================================================================== --- libvirt.orig/python/generator.py +++ libvirt/python/generator.py @@ -344,6 +344,7 @@ skip_impl = ( 'virDomainGetVcpus', 'virDomainPinVcpu', 'virDomainPinVcpuFlags', + 'virDomainGetVcpuPinInfo', 'virSecretGetValue', 'virSecretSetValue', 'virSecretGetUUID', Index: libvirt/python/libvirt-override.c =================================================================== --- libvirt.orig/python/libvirt-override.c +++ libvirt/python/libvirt-override.c @@ -784,6 +784,74 @@ libvirt_virDomainPinVcpuFlags(PyObject * return VIR_PY_INT_SUCCESS; } +static PyObject * +libvirt_virDomainGetVcpuPinInfo(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + virDomainPtr domain; + PyObject *pyobj_domain, *pycpumaps = NULL; + virNodeInfo nodeinfo; + virDomainInfo dominfo; + unsigned char *cpumaps; + int cpumaplen, vcpu, pcpu; + int flags; + int i_retval; + + if (!PyArg_ParseTuple(args, (char *)"Oi:virDomainGetVcpuPinInfo", + &pyobj_domain, &flags)) + return(NULL); + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virNodeGetInfo(virDomainGetConnect(domain), &nodeinfo); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetInfo(domain, &dominfo); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) + return VIR_PY_NONE; + + cpumaplen = VIR_CPU_MAPLEN(VIR_NODEINFO_MAXCPUS(nodeinfo)); + if ((cpumaps = malloc(dominfo.nrVirtCpu * cpumaplen)) == NULL) + goto cleanup; + memset(cpumaps, 0, dominfo.nrVirtCpu * cpumaplen); + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetVcpuPinInfo(domain, dominfo.nrVirtCpu, + cpumaps, cpumaplen, flags); + LIBVIRT_END_ALLOW_THREADS; + if (i_retval < 0) + goto cleanup; + + if ((pycpumaps = PyList_New(dominfo.nrVirtCpu)) == NULL) + goto cleanup; + + for (vcpu = 0; vcpu < dominfo.nrVirtCpu; vcpu++) { + PyObject *mapinfo = PyTuple_New(VIR_NODEINFO_MAXCPUS(nodeinfo)); + if (mapinfo == NULL) + goto cleanup; + + for (pcpu = 0; pcpu < VIR_NODEINFO_MAXCPUS(nodeinfo); pcpu++) { + PyTuple_SetItem(mapinfo, pcpu, + PyBool_FromLong(VIR_CPU_USABLE(cpumaps, cpumaplen, vcpu, pcpu))); + } + PyList_SetItem(pycpumaps, vcpu, mapinfo); + } + + free(cpumaps); + + return pycpumaps; + +cleanup: + free(cpumaps); + + if (pycpumaps) { Py_DECREF(pycpumaps);} + + return VIR_PY_NONE; +} + /************************************************************************ * * * Global error handler at the Python level * @@ -4067,6 +4135,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetVcpus", libvirt_virDomainGetVcpus, METH_VARARGS, NULL}, {(char *) "virDomainPinVcpu", libvirt_virDomainPinVcpu, METH_VARARGS, NULL}, {(char *) "virDomainPinVcpuFlags", libvirt_virDomainPinVcpuFlags, METH_VARARGS, NULL}, + {(char *) "virDomainGetVcpuPinInfo", libvirt_virDomainGetVcpuPinInfo, METH_VARARGS, NULL}, {(char *) "virConnectListStoragePools", libvirt_virConnectListStoragePools, METH_VARARGS, NULL}, {(char *) "virConnectListDefinedStoragePools", libvirt_virConnectListDefinedStoragePools, METH_VARARGS, NULL}, {(char *) "virStoragePoolGetAutostart", libvirt_virStoragePoolGetAutostart, METH_VARARGS, NULL}, Index: libvirt/python/libvirt-override-api.xml =================================================================== --- libvirt.orig/python/libvirt-override-api.xml +++ libvirt/python/libvirt-override-api.xml @@ -182,6 +182,12 @@ <arg name='cpumap' type='unsigned char *' info='pointer to a bit map of real CPUs (in 8-bit bytes) (IN) Each bit set to 1 means that corresponding CPU is usable. Bytes are stored in little-endian order: CPU0-7, 8-15... In each byte, lowest CPU number is least significant bit.'/> <arg name='flags' type='int' info='an OR'ed set of virDomainModificationImpact'/> </function> + <function name='virDomainGetVcpuPinInfo' file='python'> + <info>Query the CPU affinity setting of all virtual CPUs of domain</info> + <return type='unsigned char *' info='the array of cpumap'/> + <arg name='domain' type='virDomainPtr' info='pointer to domain object, or NULL for Domain0'/> + <arg name='flags' type='int' info='an OR'ed set of virDomainModificationImpact'/> + </function> <function name='virDomainSetSchedulerParameters' file='python'> <info>Change the scheduler parameters</info> <return type='int' info='-1 in case of error, 0 in case of success.'/>
On Fri, Jul 22, 2011 at 02:03:21PM +0900, Taku Izumi wrote:
Hi all,
This patchset adds some missing python bindings. The bindings for the following APIs are added: - virDomainGetSchedulerParametersFlags - virDomainSetSchedulerParametersFlags - virDomainPinVcpusFlags - virDomainGetVcpuPinInfo
*[PATCH 1/3] python: add Python binding for virDomainGetSchedulerParametersFlags API *[PATCH 2/3] python: add Python binding for virDomainSetSchedulerParametersFlags API *[PATCH 3/3] python: add Python binding for virDomainPinVcpusFlags API *[PATCH 4/4] python: add Python binding for virDomainGetVcpuPinInfo API
Best regards, Taku Izumi
Okay, I fixed the same int flags -> unsigned int flags nit in all 4 patches, thay all looked fine to me, and I pushed the set to master, thanks a lot ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Mon, 25 Jul 2011 15:07:41 +0800 Daniel Veillard <veillard@redhat.com> wrote:
On Fri, Jul 22, 2011 at 02:03:21PM +0900, Taku Izumi wrote:
Hi all,
This patchset adds some missing python bindings. The bindings for the following APIs are added: - virDomainGetSchedulerParametersFlags - virDomainSetSchedulerParametersFlags - virDomainPinVcpusFlags - virDomainGetVcpuPinInfo
*[PATCH 1/3] python: add Python binding for virDomainGetSchedulerParametersFlags API *[PATCH 2/3] python: add Python binding for virDomainSetSchedulerParametersFlags API *[PATCH 3/3] python: add Python binding for virDomainPinVcpusFlags API *[PATCH 4/4] python: add Python binding for virDomainGetVcpuPinInfo API
Best regards, Taku Izumi
Okay, I fixed the same int flags -> unsigned int flags nit in all 4 patches, thay all looked fine to me, and I pushed the set to master,
thanks a lot !
Thank you! -- Taku Izumi <izumi.taku@jp.fujitsu.com>
participants (2)
-
Daniel Veillard -
Taku Izumi