[libvirt] [jenkins-ci PATCH] lcitool: Fix name for ppc64le architecture
We're only exposing libvirt architecture names externally, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE). Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are indeed correct. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/lcitool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 1d17c04..d6c8105 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -100,7 +100,7 @@ class Util: "mips": "mips-linux-gnu", "mipsel": "mipsel-linux-gnu", "mips64el": "mips64el-linux-gnuabi64", - "ppc64el": "powerpc64le-linux-gnu", + "ppc64le": "powerpc64le-linux-gnu", "s390x": "s390x-linux-gnu", "x86_64": "x86_64-linux-gnu", } @@ -118,7 +118,7 @@ class Util: "mips": "mips", "mipsel": "mipsel", "mips64el": "mips64el", - "ppc64el": "ppc64el", + "ppc64le": "ppc64el", "s390x": "s390x", "x86_64": "amd64", } -- 2.20.1
On Mon, Mar 11, 2019 at 05:50:57PM +0100, Andrea Bolognani wrote:
We're only exposing libvirt architecture names externally, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE).
Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are indeed correct.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/lcitool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool index 1d17c04..d6c8105 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -100,7 +100,7 @@ class Util: "mips": "mips-linux-gnu", "mipsel": "mipsel-linux-gnu", "mips64el": "mips64el-linux-gnuabi64", - "ppc64el": "powerpc64le-linux-gnu", + "ppc64le": "powerpc64le-linux-gnu", "s390x": "s390x-linux-gnu", "x86_64": "x86_64-linux-gnu", } @@ -118,7 +118,7 @@ class Util: "mips": "mips", "mipsel": "mipsel", "mips64el": "mips64el", - "ppc64el": "ppc64el", + "ppc64le": "ppc64el",
"ppc64le": "ppc64le" I believe :) Reviewed-by: Erik Skultety <eskultet@redhat.com>
On Mon, 2019-03-11 at 18:13 +0100, Erik Skultety wrote:
On Mon, Mar 11, 2019 at 05:50:57PM +0100, Andrea Bolognani wrote: [...]
@@ -118,7 +118,7 @@ class Util: "mips": "mips", "mipsel": "mipsel", "mips64el": "mips64el", - "ppc64el": "ppc64el", + "ppc64le": "ppc64el",
"ppc64le": "ppc64le" I believe :)
Nope: this function translates libvirt architecture names to Debian architecture names, and the latter actually uses "ppc64el" for this specific architecture: see for example https://packages.debian.org/sid/ppc64el/libvirt0 Yeah, it's silly. That's why we need a translation function in the first place ;)
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Thanks, pushed now. -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Erik Skultety