[libvirt] [PATCH] rpmbuild: add ebtables & ip(6)tables dependency for rpm

Add ebtables,iptables & iptables-ipv6 dependency to rpm. Signed-off-by: Stefan Berger <stefanb@us.ibm.com> --- libvirt.spec.in | 7 +++++++ 1 file changed, 7 insertions(+) Index: libvirt-acl/libvirt.spec.in =================================================================== --- libvirt-acl.orig/libvirt.spec.in +++ libvirt-acl/libvirt.spec.in @@ -61,6 +61,7 @@ %define with_udev 0%{!?_without_udev:0} %define with_hal 0%{!?_without_hal:0} %define with_yajl 0%{!?_without_yajl:0} +%define with_nwfilter 0%{!?_without_nwfilter:0} %define with_libpcap 0%{!?_without_libpcap:0} # Non-server/HV driver defaults which are always enabled @@ -150,6 +151,7 @@ # Enable libpcap library %if %{with_qemu} +%define with_nwfilter 0%{!?_without_nwfilter:%{server_drivers}} %define with_libpcap 0%{!?_without_libpcap:%{server_drivers}} %endif @@ -195,6 +197,11 @@ Requires: bridge-utils Requires: dnsmasq Requires: iptables %endif +%if %{with_nwfilter} +Requires: ebtables +Requires: iptables +Requires: iptables-ipv6 +%endif # needed for device enumeration %if %{with_hal} Requires: hal

On 05/05/2010 05:24 AM, Stefan Berger wrote:
Add ebtables,iptables & iptables-ipv6 dependency to rpm.
Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On Wed, May 05, 2010 at 07:24:29AM -0400, Stefan Berger wrote:
Add ebtables,iptables & iptables-ipv6 dependency to rpm.
Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
--- libvirt.spec.in | 7 +++++++ 1 file changed, 7 insertions(+)
Index: libvirt-acl/libvirt.spec.in =================================================================== --- libvirt-acl.orig/libvirt.spec.in +++ libvirt-acl/libvirt.spec.in @@ -61,6 +61,7 @@ %define with_udev 0%{!?_without_udev:0} %define with_hal 0%{!?_without_hal:0} %define with_yajl 0%{!?_without_yajl:0} +%define with_nwfilter 0%{!?_without_nwfilter:0} %define with_libpcap 0%{!?_without_libpcap:0}
# Non-server/HV driver defaults which are always enabled @@ -150,6 +151,7 @@
# Enable libpcap library %if %{with_qemu} +%define with_nwfilter 0%{!?_without_nwfilter:%{server_drivers}} %define with_libpcap 0%{!?_without_libpcap:%{server_drivers}} %endif
@@ -195,6 +197,11 @@ Requires: bridge-utils Requires: dnsmasq Requires: iptables %endif +%if %{with_nwfilter} +Requires: ebtables +Requires: iptables +Requires: iptables-ipv6 +%endif # needed for device enumeration %if %{with_hal} Requires: hal
Also need to wire up the %{with_nwfilter} arg to the %configure call eg, %if ! %{with_nwfilter} %define _without_nwfilter --without-nwfilter %endif %configure \ ...snip... %{?_without_nwfilter} \ Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

"Daniel P. Berrange" <berrange@redhat.com> wrote on 05/05/2010 11:33:15 AM:
Also need to wire up the %{with_nwfilter} arg to the %configure call
eg,
%if ! %{with_nwfilter} %define _without_nwfilter --without-nwfilter %endif
%configure \ ...snip... %{?_without_nwfilter} \
It's not an option for the user to configure so that parameter cannot currently be passed and understood by configure. I did this similar to how 'secrets' is handled. Stefan
participants (3)
-
Daniel P. Berrange
-
Eric Blake
-
Stefan Berger