[PATCH V2 0/3] build: Add option to control building monolithic libvirtd
I've dusted off my old series that introduces an option to control building the monolithic libvirtd https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/CM3HV... Along with being rebased on current master, this V2 includes improvements I made while reading the patches again and running another round of build tests. Jim Fehlig (3): build: Remove unused libvirtd_socket_unit_files build: Add option to control building libvirtd spec: Add option to control building monolithic libvirtd docs/manpages/meson.build | 2 +- libvirt.spec.in | 18 +++++- meson.build | 6 +- meson_options.txt | 2 + src/remote/meson.build | 95 +++++++++++++++---------------- src/security/apparmor/meson.build | 5 +- tests/meson.build | 2 +- 7 files changed, 77 insertions(+), 53 deletions(-) -- 2.51.0
From: Jim Fehlig <jfehlig@suse.com> libvirtd_socket_unit_files is declared in src/remote/meson.build but never used. Remove it. Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- src/remote/meson.build | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/remote/meson.build b/src/remote/meson.build index 25995fdbc2..3dab585d80 100644 --- a/src/remote/meson.build +++ b/src/remote/meson.build @@ -130,14 +130,6 @@ foreach name : libvirt_conf_files set_variable(name['virtd'].underscorify(), tmp) endforeach -libvirtd_socket_unit_files = [ - 'libvirtd.socket', - 'libvirtd-ro.socket', - 'libvirtd-admin.socket', - 'libvirtd-tcp.socket', - 'libvirtd-tls.socket', -] - logrotate_files = [ 'libvirtd.qemu', 'libvirtd.lxc', -- 2.51.0
From: Jim Fehlig <jfehlig@suse.com> Add meson option 'libvirtd' to control building of the monolithic libvirtd, independent from the stateful, daemon-based drivers. E.g. meson configure -Dlibvirtd=disabled build-dir The new option defaults to 'auto' and will be enabled when 'driver_libvirtd' is enabled. Setting libvirtd=disabled skips building the libvirtd binary, and related items such as config files, systemd units, etc. The existing option 'driver_libvirtd' controls building libvirtd and all stateful, daemon-based drivers, making it unsuitable for disabling only the monolithic daemon. Additionally, 'driver_libvirtd' is used by the various libvirt-ci projects to produce a minimalistic build. Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/manpages/meson.build | 2 +- meson.build | 6 ++- meson_options.txt | 2 + src/remote/meson.build | 87 +++++++++++++++++-------------- src/security/apparmor/meson.build | 5 +- tests/meson.build | 2 +- 6 files changed, 60 insertions(+), 44 deletions(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 6504e68a71..ee686bfd1b 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -23,7 +23,7 @@ docs_man_files = [ { 'name': 'virt-qemu-sev-validate', 'section': '1', 'install': conf.has('WITH_QEMU') }, { 'name': 'libvirt-guests', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, - { 'name': 'libvirtd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, + { 'name': 'libvirtd', 'section': '8', 'install': conf.has('WITH_MONOLITHIC_LIBVIRTD') }, { 'name': 'virt-sanlock-cleanup', 'section': '8', 'install': conf.has('WITH_SANLOCK') }, { 'name': 'virt-ssh-helper', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, { 'name': 'virtbhyved', 'section': '8', 'install': conf.has('WITH_BHYVE') }, diff --git a/meson.build b/meson.build index 40d32c2697..ad1a5da1a5 100644 --- a/meson.build +++ b/meson.build @@ -1483,7 +1483,6 @@ if udev_dep.found() and not pciaccess_dep.found() error('You must install the pciaccess module to build with udev') endif - # build driver options remote_default_mode = get_option('remote_default_mode') @@ -1513,6 +1512,10 @@ if not get_option('driver_libvirtd').disabled() endif endif +if not get_option('libvirtd').disabled() and conf.has('WITH_LIBVIRTD') + conf.set('WITH_MONOLITHIC_LIBVIRTD', 1) +endif + if not get_option('driver_bhyve').disabled() and host_machine.system() == 'freebsd' conf.set('WITH_BHYVE', 1) elif get_option('driver_bhyve').enabled() @@ -2252,6 +2255,7 @@ driver_summary = { 'Libvirtd': conf.has('WITH_LIBVIRTD'), 'libxl': conf.has('WITH_LIBXL'), 'LXC': conf.has('WITH_LXC'), + 'Monolithic libvirtd': conf.has('WITH_MONOLITHIC_LIBVIRTD'), 'Network': conf.has('WITH_NETWORK'), 'OpenVZ': conf.has('WITH_OPENVZ'), 'QEMU': conf.has('WITH_QEMU'), diff --git a/meson_options.txt b/meson_options.txt index e12ace4e11..8592880b7b 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -52,6 +52,8 @@ option('udev', type: 'feature', value: 'auto', description: 'udev support') option('wireshark_dissector', type: 'feature', value: 'auto', description: 'wireshark support') option('wireshark_plugindir', type: 'string', value: '', description: 'wireshark plugins directory for use when installing wireshark plugin') +# build monolithic daemon option +option('libvirtd', type: 'feature', value: 'auto', description: 'monolithic libvirt daemon') # build driver options option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve driver') diff --git a/src/remote/meson.build b/src/remote/meson.build index 3dab585d80..3525bc34b2 100644 --- a/src/remote/meson.build +++ b/src/remote/meson.build @@ -134,9 +134,14 @@ logrotate_files = [ 'libvirtd.qemu', 'libvirtd.lxc', 'libvirtd.libxl', - 'libvirtd', ] +if conf.has('WITH_MONOLITHIC_LIBVIRTD') + logrotate_files += [ + 'libvirtd', + ] +endif + if conf.has('WITH_REMOTE') remote_driver_lib = static_library( 'virt_remote_driver', @@ -176,47 +181,49 @@ if conf.has('WITH_REMOTE') if conf.has('WITH_LIBVIRTD') guest_unit_files += files('virt-guest-shutdown.target') - virt_daemons += { - 'name': 'libvirtd', - 'c_args': [ - '-DSOCK_PREFIX="libvirt"', - '-DDAEMON_NAME="libvirtd"', - '-DWITH_IP', - '-DLIBVIRTD', - ], - } + if conf.has('WITH_MONOLITHIC_LIBVIRTD') + virt_daemons += { + 'name': 'libvirtd', + 'c_args': [ + '-DSOCK_PREFIX="libvirt"', + '-DDAEMON_NAME="libvirtd"', + '-DWITH_IP', + '-DLIBVIRTD', + ], + } - virt_daemon_confs += { - 'name': 'libvirtd', - 'with_ip': true, - } + virt_daemon_confs += { + 'name': 'libvirtd', + 'with_ip': true, + } - virt_daemon_units += { - 'service': 'libvirtd', - 'name': 'legacy monolithic', - 'service_in': files('libvirtd.service.in'), - 'service_extra_in': [ - files('libvirtd.service.extra.in'), - systemd_service_limitnofile_extra_in, - systemd_service_tasksmax_extra_in, - systemd_service_limitmemlock_extra_in, - ], - 'sockets': [ 'main', 'ro', 'admin', 'tcp', 'tls' ], - 'socket_in': files('libvirtd.socket.in'), - 'socket_ro_in': files('libvirtd-ro.socket.in'), - 'socket_admin_in': files('libvirtd-admin.socket.in'), - 'socket_tcp_in': files('libvirtd-tcp.socket.in'), - 'socket_tls_in': files('libvirtd-tls.socket.in'), - 'socket_extra_in': [ - files('libvirtd.socket.extra.in'), - ], - } + virt_daemon_units += { + 'service': 'libvirtd', + 'name': 'legacy monolithic', + 'service_in': files('libvirtd.service.in'), + 'service_extra_in': [ + files('libvirtd.service.extra.in'), + systemd_service_limitnofile_extra_in, + systemd_service_tasksmax_extra_in, + systemd_service_limitmemlock_extra_in, + ], + 'sockets': [ 'main', 'ro', 'admin', 'tcp', 'tls' ], + 'socket_in': files('libvirtd.socket.in'), + 'socket_ro_in': files('libvirtd-ro.socket.in'), + 'socket_admin_in': files('libvirtd-admin.socket.in'), + 'socket_tcp_in': files('libvirtd-tcp.socket.in'), + 'socket_tls_in': files('libvirtd-tls.socket.in'), + 'socket_extra_in': [ + files('libvirtd.socket.extra.in'), + ], + } - openrc_init_files += { - 'name': 'libvirtd', - 'in_file': files('libvirtd.init.in'), - 'confd': files('libvirtd.confd'), - } + openrc_init_files += { + 'name': 'libvirtd', + 'in_file': files('libvirtd.init.in'), + 'confd': files('libvirtd.confd'), + } + endif virt_daemons += { 'name': 'virtproxyd', @@ -337,7 +344,7 @@ endif # The monolithic libvirt daemon only attempts to load the # secrets encryption credentials if the secret driver is enabled -if conf.has('WITH_SECRETS') and init_script == 'systemd' +if conf.has('WITH_MONOLITHIC_LIBVIRTD') and conf.has('WITH_SECRETS') and init_script == 'systemd' secret_dropin_conf = configuration_data({ 'localstatedir': localstatedir, }) diff --git a/src/security/apparmor/meson.build b/src/security/apparmor/meson.build index 09d9fac02c..7585fb7100 100644 --- a/src/security/apparmor/meson.build +++ b/src/security/apparmor/meson.build @@ -1,10 +1,13 @@ apparmor_gen_profiles = [ 'usr.lib.libvirt.virt-aa-helper', - 'usr.sbin.libvirtd', 'usr.sbin.virtqemud', 'usr.sbin.virtxend', ] +if conf.has('WITH_MONOLITHIC_LIBVIRTD') + apparmor_gen_profiles += ['usr.sbin.libvirtd'] +endif + apparmor_gen_profiles_conf = configuration_data({ 'sysconfdir': sysconfdir, 'sbindir': sbindir, diff --git a/tests/meson.build b/tests/meson.build index d1d26fcea2..ea50f89fb5 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -734,7 +734,7 @@ if conf.has('WITH_TEST') ] endif -if conf.has('WITH_LIBVIRTD') +if conf.has('WITH_MONOLITHIC_LIBVIRTD') test('libvirtd fail with missing config', libvirtd_prog, args: [ '--config=no-such-conf', '--timeout=5' ], -- 2.51.0
From: Jim Fehlig <jfehlig@suse.com> Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- libvirt.spec.in | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f7f683e1c5..72fc08f9e7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -31,7 +31,10 @@ %define arches_numad %{arches_x86} %{power64} aarch64 %define arches_ch x86_64 aarch64 -# The hypervisor drivers that run in libvirtd +# The monolithic libvirtd +%define with_libvirtd 0%{!?_without_libvirtd:1} + +# The hypervisor drivers that run in monolithic libvirtd, or a modular daemon %define with_lxc 0%{!?_without_lxc:1} %define with_libxl 0%{!?_without_libxl:1} %define with_vbox 0%{!?_without_vbox:1} @@ -303,7 +306,11 @@ URL: https://libvirt.org/ %endif Source: https://download.libvirt.org/%{?mainturl}libvirt-%{version}.tar.xz +%if %{with_libvirtd} Requires: libvirt-daemon = %{version}-%{release} +%else +Obsoletes: libvirt-daemon < %(version)-%(release) +%endif Requires: libvirt-daemon-config-network = %{version}-%{release} Requires: libvirt-daemon-config-nwfilter = %{version}-%{release} %if %{with_libxl} @@ -1180,6 +1187,12 @@ echo "This RPM requires either Fedora >= %{min_fedora} or RHEL >= %{min_rhel}" exit 1 %endif +%if %{with_libvirtd} + %define arg_libvirtd -Dlibvirtd=enabled +%else + %define arg_libvirtd -Dlibvirtd=disabled +%endif + %if %{with_qemu} %define arg_qemu -Ddriver_qemu=enabled %else @@ -1363,6 +1376,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) -Dsasl=enabled \ -Dpolkit=enabled \ -Ddriver_libvirtd=enabled \ + %{?arg_libvirtd} \ -Ddriver_remote=enabled \ -Ddriver_test=enabled \ %{?arg_esx} \ @@ -2074,6 +2088,7 @@ exit 0 %doc AUTHORS.rst NEWS.rst README.rst %doc libvirt-docs/* + %if %{with_libvirtd} %files daemon %{_unitdir}/libvirtd.service %{_unitdir}/libvirtd.socket @@ -2090,6 +2105,7 @@ exit 0 %{_datadir}/augeas/lenses/tests/test_libvirtd.aug %attr(0755, root, root) %{_sbindir}/libvirtd %{_mandir}/man8/libvirtd.8* + %endif %files daemon-common %{_unitdir}/virt-guest-shutdown.target -- 2.51.0
On 7/2/26 00:55, Jim Fehlig via Devel wrote:
I've dusted off my old series that introduces an option to control building the monolithic libvirtd
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/CM3HV...
Along with being rebased on current master, this V2 includes improvements I made while reading the patches again and running another round of build tests.
Jim Fehlig (3): build: Remove unused libvirtd_socket_unit_files build: Add option to control building libvirtd spec: Add option to control building monolithic libvirtd
docs/manpages/meson.build | 2 +- libvirt.spec.in | 18 +++++- meson.build | 6 +- meson_options.txt | 2 + src/remote/meson.build | 95 +++++++++++++++---------------- src/security/apparmor/meson.build | 5 +- tests/meson.build | 2 +- 7 files changed, 77 insertions(+), 53 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Jim Fehlig -
Michal Prívozník