On 08/05/10 - 02:12:44PM, Doug Goldstein wrote:

Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support.

Signed-off-by: Doug Goldstein <cardoe@gentoo.org> --- src/qemu/qemu_conf.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 2ca3350..e92021a 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1694,6 +1694,13 @@ qemudNetworkIfaceConnect(virConnectPtr conn, qemuReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to add tap interface to bridge. " "%s is not a bridge device"), brname); + } else if (err == ENOENT) { + /* When the tun drive is missing, give a better message. */ + qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Failed to add tap interface to bridge. " + "Your kernel is missing the 'tun' module or " + "CONFIG_TUN or you need to add the " + "/dev/net/tun device node.")); } else if (template_ifname) { virReportSystemError(err, _("Failed to add tap interface to bridge '%s'"),

Yeah, this is a better error message. ACK -- Chris Lalancette