[libvirt] [PATCH] Allow libvirtd to RPC to external libvirtd.
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future. Signed-off-by: Chris Lalancette <clalance@redhat.com> --- src/remote_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index bc69c70..a416cf3 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -1001,7 +1001,7 @@ remoteOpen (virConnectPtr conn, int ret, rflags = 0; const char *autostart = getenv("LIBVIRT_AUTOSTART"); - if (inside_daemon) + if (inside_daemon && (!conn->uri || (conn->uri && !conn->uri->server))) return VIR_DRV_OPEN_DECLINED; if (!(priv = remoteAllocPrivateData(conn))) -- 1.6.0.6
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Chris, do you still need it ?
src/remote_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/remote_internal.c b/src/remote_internal.c index bc69c70..a416cf3 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -1001,7 +1001,7 @@ remoteOpen (virConnectPtr conn, int ret, rflags = 0; const char *autostart = getenv("LIBVIRT_AUTOSTART");
- if (inside_daemon) + if (inside_daemon && (!conn->uri || (conn->uri && !conn->uri->server))) return VIR_DRV_OPEN_DECLINED;
if (!(priv = remoteAllocPrivateData(conn)))
No objection myself, but it would be good if dan could voice his opinion :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Chris, do you still need it ?
Yes, I need it, but since I don't think I'll get the tunnelled stuff ready for this release, I don't need it right now. I was just trying to lay down the groundwork for the upcoming tunnelled migration stuff. -- Chris Lalancette
On Fri, Sep 04, 2009 at 09:22:30AM +0200, Chris Lalancette wrote:
Daniel Veillard wrote:
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Chris, do you still need it ?
Yes, I need it, but since I don't think I'll get the tunnelled stuff ready for this release, I don't need it right now. I was just trying to lay down the groundwork for the upcoming tunnelled migration stuff.
Well it's well identified, so I just pushed it, one less thing one will have to remember about ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (2)
-
Chris Lalancette -
Daniel Veillard