[libvirt] [PATCH] qemu: unref cfg after TerminateMachine has been called
Commit 60627f6d added the code that requests driver cfg, but forgot to unref it. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index fa894c5..b5bdb36 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -1222,6 +1222,8 @@ qemuRemoveCgroup(virQEMUDriverPtr driver, VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name); } + virObjectUnref(cfg); + return virCgroupRemove(priv->cgroup); } -- 2.1.2
On 10/21/14 12:25, Martin Kletzander wrote:
Commit 60627f6d added the code that requests driver cfg, but forgot to
Commit ID doesn't exist in libvirt.git
unref it.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index fa894c5..b5bdb36 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -1222,6 +1222,8 @@ qemuRemoveCgroup(virQEMUDriverPtr driver, VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name); }
+ virObjectUnref(cfg); + return virCgroupRemove(priv->cgroup); }
ACK with the commit ID tweaked. Peter
On Tue, Oct 21, 2014 at 01:49:37PM +0200, Peter Krempa wrote:
On 10/21/14 12:25, Martin Kletzander wrote:
Commit 60627f6d added the code that requests driver cfg, but forgot to
Commit ID doesn't exist in libvirt.git
Yep, my fault, it's 4882618ed13b469d92fa8b2b4a158fdb17dbe9f1, thanks for findinding that out ;)
unref it.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index fa894c5..b5bdb36 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -1222,6 +1222,8 @@ qemuRemoveCgroup(virQEMUDriverPtr driver, VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name); }
+ virObjectUnref(cfg); + return virCgroupRemove(priv->cgroup); }
ACK with the commit ID tweaked.
Peter
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Martin Kletzander -
Peter Krempa