[libvirt] [PATCH] Silence compiler complaints about non-literal format strings
* src/util/macvtap.c: replace _("....") with "%s", _("...") in two places --- src/util/macvtap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/macvtap.c b/src/util/macvtap.c index 736cbaf..999e670 100644 --- a/src/util/macvtap.c +++ b/src/util/macvtap.c @@ -435,13 +435,13 @@ link_add(virConnectPtr conn, malformed_resp: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("malformed netlink response message")); + "%s", _("malformed netlink response message")); VIR_FREE(recvbuf); return -1; buffer_too_small: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("internal buffer is too small")); + "%s", _("internal buffer is too small")); return -1; } -- 1.7.0.1
On 03/11/2010 04:12 PM, Laine Stump wrote:
* src/util/macvtap.c: replace _("....") with "%s", _("...") in two places --- src/util/macvtap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/macvtap.c b/src/util/macvtap.c index 736cbaf..999e670 100644 --- a/src/util/macvtap.c +++ b/src/util/macvtap.c @@ -435,13 +435,13 @@ link_add(virConnectPtr conn,
malformed_resp: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("malformed netlink response message")); + "%s", _("malformed netlink response message")); VIR_FREE(recvbuf); return -1;
buffer_too_small: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("internal buffer is too small")); + "%s", _("internal buffer is too small")); return -1; }
ACK -- Chris Lalancette
On Thu, Mar 11, 2010 at 04:52:04PM -0500, Chris Lalancette wrote:
On 03/11/2010 04:12 PM, Laine Stump wrote:
* src/util/macvtap.c: replace _("....") with "%s", _("...") in two places --- src/util/macvtap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/macvtap.c b/src/util/macvtap.c index 736cbaf..999e670 100644 --- a/src/util/macvtap.c +++ b/src/util/macvtap.c @@ -435,13 +435,13 @@ link_add(virConnectPtr conn,
malformed_resp: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("malformed netlink response message")); + "%s", _("malformed netlink response message")); VIR_FREE(recvbuf); return -1;
buffer_too_small: ReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("internal buffer is too small")); + "%s", _("internal buffer is too small")); return -1; }
ACK
yup, pushed ! thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Chris Lalancette -
Daniel Veillard -
Laine Stump